14 KiB
14 KiB
phase, plan, type, wave, depends_on, files_modified, autonomous, requirements, must_haves
| phase | plan | type | wave | depends_on | files_modified | autonomous | requirements | must_haves | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 12-branding-ui-views | 01 | execute | 1 |
|
true |
|
|
Purpose: Provides the infrastructure (converter, localization, ViewModel property) that Plans 02 and 03 need to build the XAML views.
Output: Converter with tests, localization keys (EN+FR), App.xaml registration, ClientLogoPreview property with test coverage.
<execution_context> @C:/Users/dev/.claude/get-shit-done/workflows/execute-plan.md @C:/Users/dev/.claude/get-shit-done/templates/summary.md </execution_context>
@.planning/PROJECT.md @.planning/ROADMAP.md @.planning/STATE.md @.planning/phases/12-branding-ui-views/12-RESEARCH.mdFrom SharepointToolbox/ViewModels/Tabs/SettingsViewModel.cs:
private string? _mspLogoPreview;
public string? MspLogoPreview
{
get => _mspLogoPreview;
private set { _mspLogoPreview = value; OnPropertyChanged(); }
}
// Set in LoadAsync:
var mspLogo = await _brandingService.GetMspLogoAsync();
MspLogoPreview = mspLogo is not null ? $"data:{mspLogo.MimeType};base64,{mspLogo.Base64}" : null;
// Set in BrowseMspLogoAsync:
MspLogoPreview = $"data:{logo.MimeType};base64,{logo.Base64}";
// Set in ClearMspLogoAsync:
MspLogoPreview = null;
From SharepointToolbox/ViewModels/ProfileManagementViewModel.cs (current state):
// BrowseClientLogoAsync sets SelectedProfile.ClientLogo = logo (LogoData)
// ClearClientLogoAsync sets SelectedProfile.ClientLogo = null
// AutoPullClientLogoAsync sets SelectedProfile.ClientLogo = logo
// NO ClientLogoPreview string property exists — this plan adds it
From SharepointToolbox/Core/Models/LogoData.cs:
public record LogoData
{
public string Base64 { get; init; } = string.Empty;
public string MimeType { get; init; } = string.Empty;
}
From SharepointToolbox/Views/Converters/IndentConverter.cs (converter pattern):
public class StringToVisibilityConverter : IValueConverter
{
public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
=> value is string s && !string.IsNullOrEmpty(s) ? Visibility.Visible : Visibility.Collapsed;
public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
=> throw new NotImplementedException();
}
From SharepointToolbox/App.xaml (converter registration pattern):
<conv:StringToVisibilityConverter x:Key="StringToVisibilityConverter" />
namespace SharepointToolbox.Views.Converters;
public class Base64ToImageSourceConverter : IValueConverter
{
public object? Convert(object? value, Type targetType, object? parameter, CultureInfo culture)
{
if (value is not string dataUri || string.IsNullOrEmpty(dataUri))
return null;
try
{
var marker = "base64,";
var idx = dataUri.IndexOf(marker, StringComparison.Ordinal);
if (idx < 0) return null;
var base64 = dataUri[(idx + marker.Length)..];
var bytes = System.Convert.FromBase64String(base64);
var image = new BitmapImage();
using var ms = new MemoryStream(bytes);
image.BeginInit();
image.CacheOption = BitmapCacheOption.OnLoad;
image.StreamSource = ms;
image.EndInit();
image.Freeze();
return image;
}
catch
{
return null;
}
}
public object ConvertBack(object? value, Type targetType, object? parameter, CultureInfo culture)
=> throw new NotImplementedException();
}
```
Key decisions:
- Parses data URI by finding "base64," marker — works with any mime type
- `BitmapCacheOption.OnLoad` ensures the stream can be disposed immediately
- `Freeze()` makes the image cross-thread safe (required for WPF binding)
- Catches all exceptions to avoid binding errors — returns null on failure
2. Create `SharepointToolbox.Tests/Converters/Base64ToImageSourceConverterTests.cs`:
Write tests FIRST (RED), then verify GREEN.
Use `[Trait("Category", "Unit")]` per project convention.
Note: Tests that create BitmapImage need `[STAThread]` or run on STA thread. Use xUnit's `[WpfFact]` from `Xunit.StaFact` if available, or mark tests with `[Fact]` and handle STA requirement.
For the valid data URI test, use a minimal valid 1x1 PNG base64: `iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAADUlEQVR42mNk+M9QDwADhgGAWjR9awAAAABJRU5ErkJggg==`
IMPORTANT: Check if `Xunit.StaFact` NuGet package is referenced in the test project. If not, the BitmapImage tests may need to be skipped or use a workaround (run converter logic that doesn't need STA for null/empty cases, skip the BitmapImage creation test if STA not available).
2. Add to `Strings.fr.resx` (FR):
- `settings.logo.title` = "Logo MSP"
- `settings.logo.browse` = "Importer"
- `settings.logo.clear` = "Effacer"
- `settings.logo.nopreview` = "Aucun logo configuré"
- `profile.logo.title` = "Logo client"
- `profile.logo.browse` = "Importer"
- `profile.logo.clear` = "Effacer"
- `profile.logo.autopull` = "Importer depuis Entra"
- `profile.logo.nopreview` = "Aucun logo configuré"
private static string? FormatLogoPreview(LogoData? logo)
=> logo is not null ? $"data:{logo.MimeType};base64,{logo.Base64}" : null;
```
2. Update `OnSelectedProfileChanged` to refresh preview:
```csharp
partial void OnSelectedProfileChanged(TenantProfile? value)
{
ClientLogoPreview = FormatLogoPreview(value?.ClientLogo);
// ... existing NotifyCanExecuteChanged calls ...
}
```
3. Update `BrowseClientLogoAsync` — after `SelectedProfile.ClientLogo = logo;` add:
```csharp
ClientLogoPreview = FormatLogoPreview(logo);
```
4. Update `ClearClientLogoAsync` — after `SelectedProfile.ClientLogo = null;` add:
```csharp
ClientLogoPreview = null;
```
5. Update `AutoPullClientLogoAsync` — after `SelectedProfile.ClientLogo = logo;` add:
```csharp
ClientLogoPreview = FormatLogoPreview(logo);
```
6. Update existing tests in `ProfileManagementViewModelLogoTests.cs`:
- Add test: ClientLogoPreview is null when no profile selected
- Add test: ClientLogoPreview updates when SelectedProfile with logo is selected
- Add test: ClearClientLogoAsync sets ClientLogoPreview to null
<success_criteria>
- Base64ToImageSourceConverter converts data URI strings to BitmapImage, returns null on bad input
- Converter registered in App.xaml as "Base64ToImageConverter"
- 9 localization keys present in both Strings.resx and Strings.fr.resx
- ProfileManagementViewModel.ClientLogoPreview stays in sync with SelectedProfile.ClientLogo
- All tests pass, build succeeds with zero warnings </success_criteria>