655bb79a99
All checks were successful
Release zip package / release (push) Successful in 10s
Archive 5 phases (36 plans) to milestones/v1.0-phases/. Archive roadmap, requirements, and audit to milestones/. Evolve PROJECT.md with shipped state and validated requirements. Collapse ROADMAP.md to one-line milestone summary. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
138 lines
7.0 KiB
Markdown
138 lines
7.0 KiB
Markdown
---
|
|
phase: 04-bulk-operations-and-provisioning
|
|
plan: 08
|
|
subsystem: ui
|
|
tags: [wpf, mvvm, viewmodel, view, xaml, filetransfer, csharp, converters]
|
|
|
|
requires:
|
|
- phase: 04-03
|
|
provides: FileTransferService implementing IFileTransferService
|
|
- phase: 04-07
|
|
provides: ConfirmBulkOperationDialog, FolderBrowserDialog, SitePickerDialog, localization keys for transfer.*
|
|
|
|
provides:
|
|
- TransferViewModel with source/dest selection, transfer mode, conflict policy, progress, per-item results, CSV export of failed items
|
|
- TransferView.xaml + TransferView.xaml.cs — WPF UserControl for the file transfer tab
|
|
- EnumBoolConverter and StringToVisibilityConverter added to converters file
|
|
- IFileTransferService, BulkResultCsvExportService, TransferViewModel, TransferView registered in DI
|
|
|
|
affects:
|
|
- 04-09
|
|
- 04-10
|
|
- MainWindow (tab wiring)
|
|
|
|
tech-stack:
|
|
added: []
|
|
patterns:
|
|
- TransferViewModel follows FeatureViewModelBase override pattern (RunOperationAsync, OnTenantSwitched)
|
|
- Dialog factories as Func<> set by code-behind to keep ViewModel testable
|
|
- SitePickerDialog.SelectedUrls.FirstOrDefault() for single-site transfer selection
|
|
- EnumBoolConverter for RadioButton binding to enum properties
|
|
|
|
key-files:
|
|
created:
|
|
- SharepointToolbox/ViewModels/Tabs/TransferViewModel.cs
|
|
- SharepointToolbox/Views/Tabs/TransferView.xaml
|
|
- SharepointToolbox/Views/Tabs/TransferView.xaml.cs
|
|
modified:
|
|
- SharepointToolbox/Views/Converters/IndentConverter.cs
|
|
- SharepointToolbox/App.xaml
|
|
- SharepointToolbox/App.xaml.cs
|
|
|
|
key-decisions:
|
|
- "SitePickerDialog returns SelectedUrls (list); TransferView uses .FirstOrDefault() for single-site transfer — avoids new dialog variant while reusing existing dialog"
|
|
- "EnumBoolConverter and StringToVisibilityConverter added to existing IndentConverter.cs — keeps converter classes co-located as project convention"
|
|
- "TransferViewModel exposes CurrentProfile publicly — required by code-behind to build per-site TenantProfile for FolderBrowserDialog"
|
|
|
|
patterns-established:
|
|
- "EnumBoolConverter: ConverterParameter=EnumValueName for RadioButton-to-enum binding (reusable for other enum properties in future ViewModels)"
|
|
|
|
requirements-completed:
|
|
- BULK-01
|
|
- BULK-04
|
|
- BULK-05
|
|
|
|
duration: 20min
|
|
completed: 2026-04-03
|
|
---
|
|
|
|
# Phase 04 Plan 08: TransferViewModel + TransferView Summary
|
|
|
|
**WPF file transfer tab with source/dest site+folder browser, Copy/Move mode, conflict policy, confirmation dialog, per-item result reporting, and failed-items CSV export**
|
|
|
|
## Performance
|
|
|
|
- **Duration:** 20 min
|
|
- **Started:** 2026-04-03T10:00:00Z
|
|
- **Completed:** 2026-04-03T10:20:00Z
|
|
- **Tasks:** 2
|
|
- **Files modified:** 6
|
|
|
|
## Accomplishments
|
|
|
|
- TransferViewModel wires IFileTransferService.TransferAsync with source and dest contexts acquired from ISessionManager, progress reporting, cancellation, and failed-items export via BulkResultCsvExportService
|
|
- TransferView provides a left-panel layout with source/dest GroupBoxes (site URL + browse button + library/folder display), Copy/Move radio buttons, conflict policy ComboBox (Skip/Overwrite/Rename), start/cancel buttons, progress bar, result summary, and Export Failed Items button
|
|
- Added EnumBoolConverter (for RadioButton binding) and StringToVisibilityConverter (for result summary visibility) to the converters file; registered both in App.xaml resources
|
|
- Registered IFileTransferService, BulkResultCsvExportService, TransferViewModel, TransferView in App.xaml.cs DI container
|
|
|
|
## Task Commits
|
|
|
|
1. **Tasks 1 + 2: TransferViewModel + TransferView** - `7b78b19` (feat)
|
|
|
|
## Files Created/Modified
|
|
|
|
- `SharepointToolbox/ViewModels/Tabs/TransferViewModel.cs` — ViewModel with source/dest properties, RunOperationAsync calling TransferAsync, ExportFailedAsync
|
|
- `SharepointToolbox/Views/Tabs/TransferView.xaml` — UserControl XAML with DockPanel layout
|
|
- `SharepointToolbox/Views/Tabs/TransferView.xaml.cs` — Code-behind wiring SitePickerDialog + FolderBrowserDialog factories, confirm dialog
|
|
- `SharepointToolbox/Views/Converters/IndentConverter.cs` — Added EnumBoolConverter, StringToVisibilityConverter
|
|
- `SharepointToolbox/App.xaml` — Registered EnumBoolConverter, StringToVisibilityConverter, ListToStringConverter (added by linter) as static resources
|
|
- `SharepointToolbox/App.xaml.cs` — Registered IFileTransferService, BulkResultCsvExportService, TransferViewModel, TransferView
|
|
|
|
## Decisions Made
|
|
|
|
- SitePickerDialog.SelectedUrls is a list (multi-site); used `.FirstOrDefault()` in TransferView code-behind to get the single selected site for transfer — avoids creating a new single-site variant of SitePickerDialog while reusing the established pattern.
|
|
- EnumBoolConverter added alongside existing converters in IndentConverter.cs rather than a separate file, consistent with project file convention (BytesConverter, InverseBoolConverter are also in that file).
|
|
- TransferViewModel.CurrentProfile is a public read-only property (same pattern as StorageViewModel) so the code-behind can build site-specific TenantProfile for FolderBrowserDialog acquisition.
|
|
|
|
## Deviations from Plan
|
|
|
|
### Auto-fixed Issues
|
|
|
|
**1. [Rule 1 - Bug] Adapted SitePickerDialog usage — SelectedSite vs SelectedUrls**
|
|
- **Found during:** Task 2 (TransferView code-behind)
|
|
- **Issue:** Plan referenced `sitePicker.SelectedSite` (singular property), but actual SitePickerDialog exposes `SelectedUrls` (IReadOnlyList<SiteInfo>). No SelectedSite property exists.
|
|
- **Fix:** Used `sitePicker.SelectedUrls.FirstOrDefault()` in both BrowseSource_Click and BrowseDest_Click to pick the first (or only) user selection.
|
|
- **Files modified:** SharepointToolbox/Views/Tabs/TransferView.xaml.cs
|
|
- **Verification:** Build passes with 0 errors.
|
|
- **Committed in:** 7b78b19
|
|
|
|
**2. [Rule 3 - Blocking] Added missing EnumBoolConverter and StringToVisibilityConverter**
|
|
- **Found during:** Task 2 (TransferView XAML used these converters)
|
|
- **Issue:** Plan noted converters may be missing and instructed to create them. EnumBoolConverter and StringToVisibilityConverter were not in the project.
|
|
- **Fix:** Added both converter classes to IndentConverter.cs and registered them in App.xaml.
|
|
- **Files modified:** SharepointToolbox/Views/Converters/IndentConverter.cs, SharepointToolbox/App.xaml
|
|
- **Verification:** Build passes with 0 errors; converters accessible in App.xaml.
|
|
- **Committed in:** 7b78b19
|
|
|
|
---
|
|
|
|
**Total deviations:** 2 auto-fixed (1 bug/API mismatch, 1 missing critical converters)
|
|
**Impact on plan:** Both fixes were explicitly anticipated in plan notes. No scope creep.
|
|
|
|
## Issues Encountered
|
|
|
|
- Linter auto-created a ListToStringConverter x:Key reference in App.xaml — corresponding class was added to IndentConverter.cs to satisfy the build (0 errors confirmed).
|
|
|
|
## User Setup Required
|
|
|
|
None - no external service configuration required.
|
|
|
|
## Next Phase Readiness
|
|
|
|
- TransferViewModel and TransferView are ready; must be wired into MainWindow as a tab (Plan 04-09 or 04-10).
|
|
- IFileTransferService and all DI registrations are complete; TransferView can be resolved from the DI container.
|
|
|
|
---
|
|
*Phase: 04-bulk-operations-and-provisioning*
|
|
*Completed: 2026-04-03*
|