655bb79a99
All checks were successful
Release zip package / release (push) Successful in 10s
Archive 5 phases (36 plans) to milestones/v1.0-phases/. Archive roadmap, requirements, and audit to milestones/. Evolve PROJECT.md with shipped state and validated requirements. Collapse ROADMAP.md to one-line milestone summary. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
116 lines
4.8 KiB
Markdown
116 lines
4.8 KiB
Markdown
---
|
|
phase: 03-storage
|
|
plan: 06
|
|
subsystem: ui
|
|
tags: [localization, resx, wpf, csharp, fr, en]
|
|
|
|
# Dependency graph
|
|
requires:
|
|
- phase: 03-01
|
|
provides: Models, interfaces, and project structure for Phase 3 tabs
|
|
|
|
provides:
|
|
- EN and FR localization keys for Storage tab (14 keys each)
|
|
- EN and FR localization keys for File Search tab (26 keys each)
|
|
- EN and FR localization keys for Duplicates tab (14 keys each)
|
|
- Strongly-typed Strings.Designer.cs accessors for all 54 new keys
|
|
|
|
affects:
|
|
- 03-07 (StorageViewModel/View — binds to storage keys via TranslationSource)
|
|
- 03-08 (SearchViewModel + DuplicatesViewModel + Views — binds to search/duplicates keys)
|
|
|
|
# Tech tracking
|
|
tech-stack:
|
|
added: []
|
|
patterns:
|
|
- "Dot-to-underscore key naming: key 'chk.per.lib' becomes accessor 'Strings.chk_per_lib'"
|
|
- "Manual Strings.Designer.cs maintenance (no ResXFileCodeGenerator — VS-only tool)"
|
|
- "Both .resx files use xml:space='preserve' on each <data> element"
|
|
- "New keys appended before </root> with comment block grouping by tab"
|
|
|
|
key-files:
|
|
created: []
|
|
modified:
|
|
- SharepointToolbox/Localization/Strings.resx
|
|
- SharepointToolbox/Localization/Strings.fr.resx
|
|
- SharepointToolbox/Localization/Strings.Designer.cs
|
|
|
|
key-decisions:
|
|
- "Pre-existing keys grp.scan.opts, grp.export.fmt, btn.cancel verified present — not duplicated"
|
|
- "54 new designer properties follow established dot-to-underscore naming convention"
|
|
|
|
patterns-established:
|
|
- "Phase grouping with XML comments: <!-- Phase 3: Storage Tab -->, <!-- Phase 3: File Search Tab -->, <!-- Phase 3: Duplicates Tab -->"
|
|
|
|
requirements-completed: [STOR-01, STOR-02, STOR-04, STOR-05, SRCH-01, SRCH-02, SRCH-03, SRCH-04, DUPL-01, DUPL-02, DUPL-03]
|
|
|
|
# Metrics
|
|
duration: 5min
|
|
completed: 2026-04-02
|
|
---
|
|
|
|
# Phase 03 Plan 06: Localization — Phase 3 EN and FR Keys Summary
|
|
|
|
**54 new EN/FR localization keys added across Storage, File Search, and Duplicates tabs with strongly-typed Strings.Designer.cs accessors using dot-to-underscore naming convention**
|
|
|
|
## Performance
|
|
|
|
- **Duration:** ~5 min
|
|
- **Started:** 2026-04-02T13:27:00Z
|
|
- **Completed:** 2026-04-02T13:31:33Z
|
|
- **Tasks:** 1
|
|
- **Files modified:** 3
|
|
|
|
## Accomplishments
|
|
- Added 14 Storage tab keys in both EN (Strings.resx) and FR (Strings.fr.resx): per-library breakdown, subsites, note, generate/open buttons, 7 column headers, 2 radio buttons
|
|
- Added 26 File Search tab keys in both EN and FR: search filters group, extensions/regex/date filters, creator/modifier inputs, library filter, site URL, run/open buttons, 8 column headers, 2 radio buttons
|
|
- Added 14 Duplicates tab keys in both EN and FR: duplicate type radio buttons, comparison criteria group, 5 criteria checkboxes, subsites checkbox, library placeholder, run/open buttons
|
|
- Added 54 static properties to Strings.Designer.cs following established dot-to-underscore naming convention
|
|
- Build verified: 0 errors after all localization changes
|
|
|
|
## Task Commits
|
|
|
|
Each task was committed atomically:
|
|
|
|
1. **Task 1: Add Phase 3 keys to Strings.resx, Strings.fr.resx, and Strings.Designer.cs** - `938de30` (feat)
|
|
|
|
**Plan metadata:** (to be added by final commit)
|
|
|
|
## Files Created/Modified
|
|
- `SharepointToolbox/Localization/Strings.resx` - 54 new EN data entries for Phase 3 tabs
|
|
- `SharepointToolbox/Localization/Strings.fr.resx` - 54 new FR data entries for Phase 3 tabs
|
|
- `SharepointToolbox/Localization/Strings.Designer.cs` - 54 new static property accessors
|
|
|
|
## Decisions Made
|
|
None - followed plan as specified. Pre-existing keys verified with git stash/pop workflow to confirm build was clean before changes, and test failures confirmed pre-existing (from export service stubs planned for 03-03/03-05).
|
|
|
|
## Deviations from Plan
|
|
|
|
None - plan executed exactly as written.
|
|
|
|
**Note:** Build had a transient CS1929 error on first invocation (stale compiled artifacts). Second `dotnet build` succeeded with 0 errors. The 9 test failures are pre-existing (export service stubs from plans 03-03/03-05, verified by stashing changes).
|
|
|
|
## Issues Encountered
|
|
- Transient build error CS1929 on first `dotnet build` invocation (stale .NET temp project files). Resolved automatically on second build.
|
|
|
|
## User Setup Required
|
|
|
|
None - no external service configuration required.
|
|
|
|
## Next Phase Readiness
|
|
- All Phase 3 localization keys now present — plans 03-07 and 03-08 can use `TranslationSource.Instance["key"]` XAML bindings without missing-key issues
|
|
- Wave 3: StorageViewModel/View (03-07) is unblocked
|
|
- Wave 4: SearchViewModel + DuplicatesViewModel + Views (03-08) is unblocked
|
|
|
|
## Self-Check: PASSED
|
|
|
|
- FOUND: SharepointToolbox/Localization/Strings.resx
|
|
- FOUND: SharepointToolbox/Localization/Strings.fr.resx
|
|
- FOUND: SharepointToolbox/Localization/Strings.Designer.cs
|
|
- FOUND: .planning/phases/03-storage/03-06-SUMMARY.md
|
|
- FOUND: commit 938de30
|
|
|
|
---
|
|
*Phase: 03-storage*
|
|
*Completed: 2026-04-02*
|