kawaandClaude Haiku 4.5
ed41f7f520
Printers and groups (Client) are now scoped to an Owner identified by an opaque
bearer key (secrets.token_urlsafe(32)) stored in an httponly cookie, defaulting
to temporary. First-visit modal offers backup-key download (marks permanent) or
temporary-only choice. /session/restore re-attaches a fresh browser to a saved
key. Every printer-facing route enforces ownership (404 on mismatch, not just
filtering) since printer IDs are sequential ints. Drivers stay global/shared.
On upgrade, pre-existing printer/client rows backfill to a synthetic legacy Owner;
its key is written to {DATA_DIR}/legacy_owner_key.txt for manual restore.
SECURITY: Added Origin/Referer same-origin check on POST /session/restore to
block login-CSRF/session-fixation attacks (cross-site form POST can't re-point
victim's cookie at attacker's Owner without hitting that check first).
Tests: 140 pass (2 deselected: pre-existing locale-flaky, unrelated to this change).
Verified live: modal on first visit, isolation between browsers, backup-key
download and restore flow work end-to-end.
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
55 lines
1.7 KiB
Python
55 lines
1.7 KiB
Python
"""Client CRUD API — POST /clients, GET /clients."""
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
|
|
from fastapi import APIRouter, Form, Request
|
|
from fastapi.responses import HTMLResponse
|
|
from fastapi.templating import Jinja2Templates
|
|
from peewee import IntegrityError
|
|
|
|
from imptune.db.models import Client
|
|
|
|
router = APIRouter(prefix="/clients")
|
|
|
|
templates = Jinja2Templates(
|
|
directory=str(Path(__file__).parent.parent / "templates")
|
|
)
|
|
|
|
|
|
def _error_response(message: str, status_code: int = 400) -> HTMLResponse:
|
|
"""Return an HTMX-friendly error fragment swapped into #client-list."""
|
|
return HTMLResponse(
|
|
content=f"<div id='client-list' class='error'><p>{message}</p></div>",
|
|
status_code=status_code,
|
|
)
|
|
|
|
|
|
def _render_client_list(request: Request) -> HTMLResponse:
|
|
"""Render the client list partial for HTMX swap."""
|
|
clients = list(Client.select().where(Client.owner == request.state.owner).order_by(Client.name))
|
|
return templates.TemplateResponse(
|
|
request=request,
|
|
name="partials/client_list.html",
|
|
context={"clients": clients},
|
|
)
|
|
|
|
|
|
@router.post("", response_class=HTMLResponse)
|
|
def create_client(request: Request, name: str = Form(...)) -> HTMLResponse:
|
|
"""Create a new client.
|
|
|
|
Accepts form-encoded `name`. Validates non-empty. Returns HTMX partial
|
|
with updated client list on success, or error fragment on failure.
|
|
"""
|
|
name = name.strip()
|
|
if not name:
|
|
return _error_response("Client name is required.")
|
|
|
|
try:
|
|
Client.create(name=name, owner=request.state.owner)
|
|
except IntegrityError:
|
|
return _error_response(f"Client '{name}' already exists.", status_code=409)
|
|
|
|
return _render_client_list(request)
|