kawaandClaude Opus 5
2c06806814
Driver rename and icons: `Driver.display_name` plus a `DriverIcon` table, both global/shared like the `Driver` row they hang off, so a rename or an icon is what every Owner sees. The rename/icon dialog keeps its forms as siblings (nested forms are invalid HTML) and the icon routes return an `hx-swap-oob` thumbnail refresh rather than re-rendering the table, which would tear the open `<dialog>` out of the DOM. Web image picker: `GET /web/images` renders a pickable grid for a printer or a driver icon, with the search term prefilled from the entity name and editable. Picking one downloads it server-side and normalizes it. Driver download search: `GET /web/drivers` searches for a vendor-wide driver (the term is rewritten into the vendor's real product name for 15 brands) or for the exact model as typed. Links only — nothing is downloaded, and the fragment says the results are unvetted. Icon uploads no longer reject off-size or non-PNG files: `normalize_icon()` letterboxes any decodable raster into a 256x256 PNG. An already-exact 256x256 PNG is returned byte-identical, because icon storage is content-addressed and re-encoding would move the file on every save. `fetch_image()` makes the request from the server, so `assert_fetchable()` refuses any URL resolving to a private, loopback, or link-local address, and re-runs on every redirect. ImpTune sits on the same LAN as the printers it configures; an unguarded fetcher would be a port scanner for anyone who can reach the UI. DuckDuckGo is scraped, not called through an API — no key needed, but fragile, so both search functions swallow parse failures and return [] instead of 500ing a page. `WEB_SEARCH=false` disables every outbound request and hides the controls, for air-gapped installs. Also: one shared `Jinja2Templates` in `templating.py` instead of five per-router instances, so a template global is declared once; `_add_missing_columns()` in `database.py` adds new nullable columns to a pre-existing table, which `create_tables(safe=True)` skips; `db_env` in test_db.py now closes its connection on teardown, or the next test's ORM writes land in the previous test's DB file. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
53 lines
1.8 KiB
Python
53 lines
1.8 KiB
Python
"""Client CRUD API — POST /clients, GET /clients."""
|
|
from __future__ import annotations
|
|
|
|
from fastapi import APIRouter, Form, Request
|
|
from fastapi.responses import HTMLResponse
|
|
from peewee import IntegrityError
|
|
|
|
from imptune.db.models import Client
|
|
from imptune.templating import templates
|
|
|
|
router = APIRouter(prefix="/clients")
|
|
|
|
|
|
def _error_response(message: str, status_code: int = 400) -> HTMLResponse:
|
|
"""Return an HTMX-friendly error fragment swapped into #client-list."""
|
|
return HTMLResponse(
|
|
content=f"<div id='client-list' class='error'><p>{message}</p></div>",
|
|
status_code=status_code,
|
|
)
|
|
|
|
|
|
def _render_client_list(request: Request) -> HTMLResponse:
|
|
"""Render the client list partial for HTMX swap."""
|
|
from imptune.api.pages import printer_counts_by_client
|
|
|
|
owner = request.state.owner
|
|
clients = list(Client.select().where(Client.owner == owner).order_by(Client.name))
|
|
return templates.TemplateResponse(
|
|
request=request,
|
|
name="partials/client_list.html",
|
|
# Counts must come along, or the swapped-in rows all read "0 printers".
|
|
context={"clients": clients, "counts": printer_counts_by_client(owner)},
|
|
)
|
|
|
|
|
|
@router.post("", response_class=HTMLResponse)
|
|
def create_client(request: Request, name: str = Form(...)) -> HTMLResponse:
|
|
"""Create a new client.
|
|
|
|
Accepts form-encoded `name`. Validates non-empty. Returns HTMX partial
|
|
with updated client list on success, or error fragment on failure.
|
|
"""
|
|
name = name.strip()
|
|
if not name:
|
|
return _error_response("Client name is required.")
|
|
|
|
try:
|
|
Client.create(name=name, owner=request.state.owner)
|
|
except IntegrityError:
|
|
return _error_response(f"Client '{name}' already exists.", status_code=409)
|
|
|
|
return _render_client_list(request)
|