kawa/Crystal
2
0 Fork 0
Code Issues 41 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

Dialogue choices should be a box above the text box, as in the original #67

New Issue
Closed
opened 2026-10-04 01:20:57 +02:00 by PestoRosso · 2 comments
PestoRosso commented 2026-10-04 01:20:57 +02:00
Collaborator
Copy link
Copy source

Reported by QA (PestoRosso)

Steps
Open any choice in the overworld dialogue: the bedroom PC menu, a YES/NO question such as picking a starter, and so on.

Actual
The choices are drawn inside the dialogue (text) box, to the right of the text. That is also what clipped the PC menu (#65).

Expected (original game)
Every choice (menus, YES/NO and the amount boxes) is a box of its own, above the text box and aligned to the right. The text box stays below with only the text. See the reference emulator on the bedroom PC.

Notes

  • Related to #64 (YES/NO vertical) and #65 (PC menu cut off), which this layout also resolves.
  • The ids #dialogue-choice and #native-dialogue are unchanged, so tests that use them keep working.
  • The app-only CANCEL button under the menu list is removed for parity; B (also the on-screen B button) leaves the menu, as in the original.
  • The cursor marker reserves its width on every entry, so the box no longer changes size as the cursor moves.
**Reported by QA (PestoRosso)** **Steps** Open any choice in the overworld dialogue: the bedroom PC menu, a YES/NO question such as picking a starter, and so on. **Actual** The choices are drawn inside the dialogue (text) box, to the right of the text. That is also what clipped the PC menu (#65). **Expected (original game)** Every choice (menus, YES/NO and the amount boxes) is a box of its own, above the text box and aligned to the right. The text box stays below with only the text. See the reference emulator on the bedroom PC. **Notes** - Related to #64 (YES/NO vertical) and #65 (PC menu cut off), which this layout also resolves. - The ids `#dialogue-choice` and `#native-dialogue` are unchanged, so tests that use them keep working. - The app-only CANCEL button under the menu list is removed for parity; B (also the on-screen B button) leaves the menu, as in the original. - The cursor marker reserves its width on every entry, so the box no longer changes size as the cursor moves.
PestoRosso added the P1 - nextparity labels 2026-10-04 01:20:57 +02:00
PestoRosso self-assigned this 2026-10-04 01:20:57 +02:00
PestoRosso commented 2026-10-04 16:24:26 +02:00
Author
Collaborator
Copy link
Copy source

Fixed in 525ff09 (with the choice layout work in 5546e57), pushed to main. All dialogue choices are now a box above the text box, as in the original.

Fixed in 525ff09 (with the choice layout work in 5546e57), pushed to main. All dialogue choices are now a box above the text box, as in the original.
PestoRosso added this to the Pokemon Crystal - Web project 2026-10-04 16:24:38 +02:00
PestoRosso moved this to Fait in Pokemon Crystal - Web on 2026-10-04 16:24:38 +02:00
kawa commented 2026-10-06 14:48:12 +02:00
Owner
Copy link
Copy source

Regression on phone viewports: the floating choice box lets the start menu overflow the top of the game screen, so POKéDEX/POKéMON/PACK cannot be tapped. Tracked in #70.

Regression on phone viewports: the floating choice box lets the start menu overflow the top of the game screen, so POKéDEX/POKéMON/PACK cannot be tapped. Tracked in #70.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
P0 - now
Do first
 P1 - next
Do after P0
 P2 - later
Lower priority
 P3 - someday
Nice to have, lowest priority
 Parked
Not on the roadmap for now
 parity
Serves the 1:1 reproduction of the original game
No labels P1 - next parity
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Pokemon Crystal - Web
Fait
Assignees
Clear assignees
PestoRosso samy kawa (Sébastien QUEROL)
No Assignees PestoRosso
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kawa/Crystal#67