kawa/Crystal
2
0 Fork 0
Code Issues 41 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

Choice boxes: the cursor moves up/down but the buttons are laid out side by side #64

New Issue
Closed
opened 2026-10-03 19:15:44 +02:00 by PestoRosso · 1 comment
PestoRosso commented 2026-10-03 19:15:44 +02:00
Collaborator
Copy link
Copy source

Reported by QA (PestoRosso)

Problem
Several choice boxes move their cursor with Up/Down, but the buttons are drawn side by side (left/right).

Steps

  1. Reach Elm's lab and pick a starter Pokémon ball: YES and NO are side by side.
  2. In a battle, open FIGHT or PACK, or get a YES/NO question: the options are laid out in two columns, but Up/Down moves through them one by one.

Expected (original game)
The cursor moves the way the choices are drawn: YES above NO, one move or item per row, and the FIGHT / PKMN / PACK / RUN menu as a 2x2 grid where Down from FIGHT reaches PACK.

Scope

  • The dialogue YES/NO box (starters, nicknames, shops, PC and so on) is now vertical.
  • Battle choices other than the main menu (YES/NO, moves, pack items, party) are now one column.
  • The battle menu's cursor follows the drawn layout (adjacentButton in src/main.ts) instead of stepping through the buttons in order.
  • The Pokégear, trainer card, options and Fly map read the controls directly and are not affected.

Notes

  • The cursor no longer wraps around at the ends of the battle menu. The original does not wrap either.
  • tests/battle-browser.spec.ts assumed the old order (Down from FIGHT reached PKMN); it now expects the 2x2 behaviour. It needs the ROM, so it has not been run.
**Reported by QA (PestoRosso)** **Problem** Several choice boxes move their cursor with Up/Down, but the buttons are drawn side by side (left/right). **Steps** 1. Reach Elm's lab and pick a starter Pokémon ball: YES and NO are side by side. 2. In a battle, open FIGHT or PACK, or get a YES/NO question: the options are laid out in two columns, but Up/Down moves through them one by one. **Expected (original game)** The cursor moves the way the choices are drawn: YES above NO, one move or item per row, and the FIGHT / PKMN / PACK / RUN menu as a 2x2 grid where Down from FIGHT reaches PACK. **Scope** - The dialogue YES/NO box (starters, nicknames, shops, PC and so on) is now vertical. - Battle choices other than the main menu (YES/NO, moves, pack items, party) are now one column. - The battle menu's cursor follows the drawn layout (`adjacentButton` in `src/main.ts`) instead of stepping through the buttons in order. - The Pokégear, trainer card, options and Fly map read the controls directly and are not affected. **Notes** - The cursor no longer wraps around at the ends of the battle menu. The original does not wrap either. - `tests/battle-browser.spec.ts` assumed the old order (Down from FIGHT reached PKMN); it now expects the 2x2 behaviour. It needs the ROM, so it has not been run.
PestoRosso added the P1 - nextparity labels 2026-10-03 19:15:44 +02:00
PestoRosso self-assigned this 2026-10-03 19:15:44 +02:00
PestoRosso changed title from YES/NO box shows side by side; it should be vertical (Up/Down) to Choice boxes: the cursor moves up/down but the buttons are laid out side by side 2026-10-03 19:23:59 +02:00
PestoRosso commented 2026-10-04 16:25:22 +02:00
Author
Collaborator
Copy link
Copy source

Fixed in 5546e57 (YES/NO and battle lists as single columns, the battle cursor following the 2x2 grid) and 525ff09 (choice boxes above the text box), pushed to main.

Fixed in 5546e57 (YES/NO and battle lists as single columns, the battle cursor following the 2x2 grid) and 525ff09 (choice boxes above the text box), pushed to main.
PestoRosso added this to the Pokemon Crystal - Web project 2026-10-04 16:25:23 +02:00
PestoRosso moved this to Fait in Pokemon Crystal - Web on 2026-10-04 16:25:23 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
P0 - now
Do first
 P1 - next
Do after P0
 P2 - later
Lower priority
 P3 - someday
Nice to have, lowest priority
 Parked
Not on the roadmap for now
 parity
Serves the 1:1 reproduction of the original game
No labels P1 - next parity
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Pokemon Crystal - Web
Fait
Assignees
Clear assignees
PestoRosso samy kawa (Sébastien QUEROL)
No Assignees PestoRosso
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kawa/Crystal#64