- 19-01-SUMMARY.md: service layer implementation with rollback pattern - STATE.md: progress 98%, decisions added, session updated - ROADMAP.md: phase 19 in-progress (1/2 plans) - REQUIREMENTS.md: APPREG-02, APPREG-03, APPREG-06 marked complete
4.9 KiB
4.9 KiB
gsd_state_version, milestone, milestone_name, status, stopped_at, last_updated, last_activity, progress
| gsd_state_version | milestone | milestone_name | status | stopped_at | last_updated | last_activity | progress | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1.0 | v2.3 | Tenant Management & Report Enhancements | planning | Completed 19-01-PLAN.md | 2026-04-09T13:15:04.040Z | 2026-04-09 — Roadmap created for v2.3 (phases 15-19) |
|
Project State
Project Reference
See: .planning/PROJECT.md (updated 2026-04-09)
Core value: Administrators can audit and manage SharePoint/Teams permissions and storage across multiple client tenants from a single, reliable desktop application. Current focus: v2.3 Tenant Management & Report Enhancements — Phase 15 next
Current Position
Phase: 15 — Consolidation Data Model (not started) Plan: — Status: Roadmap approved — ready to plan Phase 15 Last activity: 2026-04-09 — Roadmap created for v2.3 (phases 15-19)
v2.3 Progress: ░░░░░░░░░░ 0% (0/5 phases)
Shipped Milestones
- v1.0 MVP — Phases 1-5 (shipped 2026-04-07)
- v1.1 Enhanced Reports — Phases 6-9 (shipped 2026-04-08)
- v2.2 Report Branding & User Directory — Phases 10-14 (shipped 2026-04-09)
v2.3 Phase Map
| Phase | Name | Requirements | Status |
|---|---|---|---|
| 15 | Consolidation Data Model | RPT-04 | Not started |
| 16 | Report Consolidation Toggle | RPT-03 | Not started |
| 17 | Group Expansion in HTML Reports | RPT-01, RPT-02 | Not started |
| 18 | Auto-Take Ownership | OWN-01, OWN-02 | Not started |
| 19 | App Registration & Removal | APPREG-01..06 | Not started |
Accumulated Context
Decisions
Decisions are logged in PROJECT.md Key Decisions table.
v2.3 notable constraints:
- Phase 19 has the highest blast radius (Entra changes) — must be last
- Phase 15 is zero-API-call foundation; unblocks Phase 16 (consolidation) and Phase 18 (ownership) independently
- Group expansion (Phase 17) calls Graph at export time, not at scan time — scan pipeline unchanged
- Auto-take ownership uses PnP
Tenant.SetSiteAdmin— requires Tenant Admin scope - App registration must be atomic with rollback; partial Entra state is worse than no state
- [Phase 15]: MakeKey declared internal for test access via InternalsVisibleTo without exposing as public API
- [Phase 15]: LINQ GroupBy+Select for consolidation merge instead of mutable dictionary — consistent with functional codebase style
- [Phase 15-consolidation-data-model]: RPT-04-g test data uses 11 rows (not 10) to produce 7 consolidated rows — plan description had a counting error; 4 unique rows + 3 merged groups = 7
- [Phase 16-01]: Consolidated branch uses early-return pattern inside WriteSingleFileAsync to leave existing code path untouched
- [Phase 16-01]: PermissionsViewModel gets MergePermissions as no-op placeholder reserved for future use
- [Phase 16-report-consolidation-toggle]: BuildConsolidatedHtml is a private method via early-return in BuildHtml — existing code path completely untouched
- [Phase 16-report-consolidation-toggle]: Separate locIdx counter for location groups (loc0, loc1...) distinct from grpIdx for user groups (ugrp0...) prevents ID collision
- [Phase 17]: Static helpers IsAadGroup/ExtractAadGroupId/StripClaims declared internal to enable unit testing via InternalsVisibleTo without polluting public API
- [Phase 17]: Graph client created lazily on first AAD group encountered to avoid unnecessary auth overhead for groups with no nested AAD members
- [Phase 17]: groupMembers optional param in HtmlExportService — null produces identical pre-Phase-17 output; ISharePointGroupResolver injected as optional last param in PermissionsViewModel; resolution failure degrades gracefully with LogWarning
- [Phase 18-auto-take-ownership]: OwnershipElevationService uses Tenant.SetSiteAdmin from PnP.Framework
- [Phase 18-auto-take-ownership]: WasAutoElevated last positional param with default=false preserves all existing PermissionEntry callsites
- [Phase 18-auto-take-ownership]: AutoTakeOwnership ViewModel setter uses fire-and-forget pattern matching DataFolder
- [Phase 18-auto-take-ownership]: Toggle read before scan loop (not in exception filter) — await in when clause unsupported; pre-read bool preserves semantics
- [Phase 18-auto-take-ownership]: WasAutoElevated DataTrigger last in RowStyle.Triggers — amber wins over RiskLevel color
- [Phase 19-app-registration-removal]: AppRegistrationService uses AppGraphClientFactory alias to disambiguate from Microsoft.Graph.GraphClientFactory
- [Phase 19-app-registration-removal]: BuildRequiredResourceAccess declared internal to enable direct unit testing without live Graph calls
- [Phase 19-app-registration-removal]: SharePoint AllSites.FullControl GUID marked LOW confidence — must be verified against live tenant
Pending Todos
None.
Blockers/Concerns
None.
Session Continuity
Last session: 2026-04-09T13:15:04.038Z
Stopped at: Completed 19-01-PLAN.md
Resume file: None
Next step: /gsd:plan-phase 15