9.5 KiB
9.5 KiB
phase, plan, type, wave, depends_on, files_modified, autonomous, requirements, must_haves
| phase | plan | type | wave | depends_on | files_modified | autonomous | requirements | must_haves | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 11-html-export-branding | 03 | execute | 3 |
|
|
true |
|
|
Purpose: Connects the branding infrastructure (Plan 01) and export service changes (Plan 02) to the user-facing export commands. After this plan, HTML exports include branding logos when configured.
Output: All 5 export ViewModels inject IBrandingService, assemble ReportBranding in ExportHtmlAsync, and pass it to WriteAsync.
<execution_context> @C:/Users/dev/.claude/get-shit-done/workflows/execute-plan.md @C:/Users/dev/.claude/get-shit-done/templates/summary.md </execution_context>
@.planning/PROJECT.md @.planning/ROADMAP.md @.planning/phases/11-html-export-branding/11-CONTEXT.md @.planning/phases/11-html-export-branding/11-RESEARCH.md @.planning/phases/11-html-export-branding/11-02-SUMMARY.md From SharepointToolbox/Core/Models/ReportBranding.cs: ```csharp public record ReportBranding(LogoData? MspLogo, LogoData? ClientLogo); ```From SharepointToolbox/Services/IBrandingService.cs:
public interface IBrandingService
{
Task<LogoData> ImportLogoAsync(string filePath);
Task SaveMspLogoAsync(LogoData logo);
Task ClearMspLogoAsync();
Task<LogoData?> GetMspLogoAsync();
}
DuplicatesViewModel constructor pattern:
public DuplicatesViewModel(
IDuplicatesService duplicatesService,
ISessionManager sessionManager,
DuplicatesHtmlExportService htmlExportService,
ILogger<FeatureViewModelBase> logger) : base(logger)
Each ViewModel has:
private TenantProfile? _currentProfile;field set via OnTenantSwitchedExportHtmlAsync()method calling_htmlExportService.WriteAsync(..., CancellationToken.None)
PermissionsViewModel has two constructors: full (DI) and test (internal, omits export services). UserAccessAuditViewModel also has two constructors. StorageViewModel also has two constructors (test constructor at line 151). The other 2 ViewModels (Search, Duplicates) have a single constructor each.
DI registrations in App.xaml.cs:
services.AddSingleton<IBrandingService, BrandingService>();
IBrandingService is already registered — no new DI registration needed for the service itself. But each ViewModel registration must now resolve IBrandingService in addition to existing deps.
Task 1: Inject IBrandingService into all 5 export ViewModels and assemble branding in ExportHtmlAsync SharepointToolbox/ViewModels/Tabs/PermissionsViewModel.cs, SharepointToolbox/ViewModels/Tabs/SearchViewModel.cs, SharepointToolbox/ViewModels/Tabs/StorageViewModel.cs, SharepointToolbox/ViewModels/Tabs/DuplicatesViewModel.cs, SharepointToolbox/ViewModels/Tabs/UserAccessAuditViewModel.cs Apply the same pattern to all 5 ViewModels:**For each ViewModel:**
1. Add `using SharepointToolbox.Core.Models;` if not already present (needed for `ReportBranding`).
2. Add field: `private readonly IBrandingService _brandingService;`
3. Modify the DI constructor to accept `IBrandingService brandingService` parameter and assign `_brandingService = brandingService;`.
4. For ViewModels with a test constructor (PermissionsViewModel, UserAccessAuditViewModel, StorageViewModel): add `IBrandingService? brandingService = null` as the last parameter, assign `_brandingService = brandingService!;`. Using `null!` is acceptable because test constructors are only used in tests where branding is not exercised. Alternatively, create a no-op implementation — but `null!` matches existing pattern where `_htmlExportService = null` is already used in test constructors. **Verify that existing test files for all 3 ViewModels still compile after the constructor changes.**
5. Modify `ExportHtmlAsync()` — add branding assembly BEFORE the WriteAsync call:
```csharp
// Assemble branding
var mspLogo = await _brandingService.GetMspLogoAsync();
var clientLogo = _currentProfile?.ClientLogo;
var branding = new ReportBranding(mspLogo, clientLogo);
```
Then pass `branding` as the last argument to each `WriteAsync` call.
**Specific details per ViewModel:**
**PermissionsViewModel** (2 WriteAsync calls in ExportHtmlAsync):
```csharp
// Before:
await _htmlExportService.WriteAsync(SimplifiedResults.ToList(), dialog.FileName, CancellationToken.None);
// After:
await _htmlExportService.WriteAsync(SimplifiedResults.ToList(), dialog.FileName, CancellationToken.None, branding);
```
Same for the non-simplified path.
**SearchViewModel** (1 WriteAsync call):
```csharp
await _htmlExportService.WriteAsync(Results, dialog.FileName, CancellationToken.None, branding);
```
**StorageViewModel** (1 WriteAsync call — the one with FileTypeMetrics):
```csharp
await _htmlExportService.WriteAsync(Results, FileTypeMetrics, dialog.FileName, CancellationToken.None, branding);
```
**DuplicatesViewModel** (1 WriteAsync call):
```csharp
await _htmlExportService.WriteAsync(_lastGroups, dialog.FileName, CancellationToken.None, branding);
```
**UserAccessAuditViewModel** (1 WriteAsync call):
```csharp
await _htmlExportService.WriteAsync(Results, dialog.FileName, CancellationToken.None, branding);
```
**Guard clause:** Add a null check on `_brandingService` before the branding assembly to be safe (in case the test constructor was used). If `_brandingService is null`, set `branding = null` (which means no branding header — graceful degradation):
```csharp
ReportBranding? branding = null;
if (_brandingService is not null)
{
var mspLogo = await _brandingService.GetMspLogoAsync();
var clientLogo = _currentProfile?.ClientLogo;
branding = new ReportBranding(mspLogo, clientLogo);
}
```
<success_criteria>
- All 5 export ViewModels have IBrandingService injected via constructor
- ExportHtmlAsync assembles ReportBranding from GetMspLogoAsync + _currentProfile.ClientLogo
- ReportBranding is passed to WriteAsync as the last parameter
- Test constructors handle null IBrandingService gracefully (branding = null fallback)
- All existing ViewModel and export tests pass without modification
- Build succeeds with zero warnings </success_criteria>