---
phase: 11-html-export-branding
plan: 03
subsystem: viewmodels
tags: [html-export, branding, csharp, viewmodels, dotnet]

# Dependency graph
requires:
  - phase: 11-01
    provides: ReportBranding record
  - phase: 11-02
    provides: Optional ReportBranding? branding parameter on all 5 export service WriteAsync methods
  - phase: 10
    provides: IBrandingService registered as singleton in DI; IBrandingService.GetMspLogoAsync()
provides:
  - PermissionsViewModel with IBrandingService injection and branding assembly in ExportHtmlAsync
  - SearchViewModel with IBrandingService injection and branding assembly in ExportHtmlAsync
  - StorageViewModel with IBrandingService injection and branding assembly in ExportHtmlAsync
  - DuplicatesViewModel with IBrandingService injection and branding assembly in ExportHtmlAsync
  - UserAccessAuditViewModel with IBrandingService injection and branding assembly in ExportHtmlAsync
affects:
  - HTML export output (branding header injected when MSP or client logo is configured)

# Tech tracking
tech-stack:
  added: []
  patterns:
    - "IBrandingService injected via DI constructor; optional IBrandingService? in test constructors with null default"
    - "Guard clause pattern: branding = null when _brandingService is null (graceful degradation in tests)"
    - "ReportBranding assembled from GetMspLogoAsync() + _currentProfile?.ClientLogo before each WriteAsync call"

key-files:
  created: []
  modified:
    - SharepointToolbox/ViewModels/Tabs/PermissionsViewModel.cs
    - SharepointToolbox/ViewModels/Tabs/SearchViewModel.cs
    - SharepointToolbox/ViewModels/Tabs/StorageViewModel.cs
    - SharepointToolbox/ViewModels/Tabs/DuplicatesViewModel.cs
    - SharepointToolbox/ViewModels/Tabs/UserAccessAuditViewModel.cs

key-decisions:
  - "Test constructors (PermissionsViewModel, StorageViewModel, UserAccessAuditViewModel) use optional IBrandingService? brandingService = null as last parameter — preserves all existing test call sites without modification"
  - "DuplicatesViewModel and SearchViewModel have single constructors only — IBrandingService added as required DI parameter"
  - "No App.xaml.cs changes needed — ViewModels registered as AddTransient<T>() with auto-resolution; IBrandingService already registered as singleton in Phase 10"
  - "Guard clause uses 'if (_brandingService is not null)' pattern — branding = null fallback means export services render without header (backward compatible)"

# Metrics
duration: 3min
completed: 2026-04-08
---

# Phase 11 Plan 03: ViewModel Branding Wiring Summary

**IBrandingService injected into all 5 export ViewModels; ReportBranding assembled from MSP logo + active tenant ClientLogo and passed to WriteAsync in each ExportHtmlAsync method**

## Performance

- **Duration:** ~3 min
- **Started:** 2026-04-08T12:47:55Z
- **Completed:** 2026-04-08T12:51:00Z
- **Tasks:** 1
- **Files modified:** 5

## Accomplishments

- Added `private readonly IBrandingService? _brandingService;` field to PermissionsViewModel, StorageViewModel, UserAccessAuditViewModel (nullable for test constructors)
- Added `private readonly IBrandingService _brandingService;` field to SearchViewModel and DuplicatesViewModel (non-nullable, single constructor)
- Modified DI constructors on all 5 ViewModels to accept `IBrandingService brandingService` parameter
- Modified test constructors on PermissionsViewModel, StorageViewModel, UserAccessAuditViewModel to accept optional `IBrandingService? brandingService = null` as last parameter — all existing test call sites compile unchanged
- Added branding assembly block with guard clause in ExportHtmlAsync for all 5 ViewModels
- Passed `branding` as last argument to WriteAsync in all ExportHtmlAsync methods (2 calls in PermissionsViewModel, 1 each in the other 4)
- No App.xaml.cs changes required — DI auto-resolves IBrandingService for all ViewModel registrations

## Task Commits

1. **Task 1: Inject IBrandingService into all 5 export ViewModels** - `816fb5e` (feat)

## Files Created/Modified

- `SharepointToolbox/ViewModels/Tabs/PermissionsViewModel.cs` - IBrandingService field + DI ctor param + optional test ctor param + branding in ExportHtmlAsync (2 WriteAsync calls)
- `SharepointToolbox/ViewModels/Tabs/SearchViewModel.cs` - IBrandingService field + DI ctor param + branding in ExportHtmlAsync
- `SharepointToolbox/ViewModels/Tabs/StorageViewModel.cs` - IBrandingService field + DI ctor param + optional test ctor param + branding in ExportHtmlAsync
- `SharepointToolbox/ViewModels/Tabs/DuplicatesViewModel.cs` - IBrandingService field + DI ctor param + branding in ExportHtmlAsync
- `SharepointToolbox/ViewModels/Tabs/UserAccessAuditViewModel.cs` - IBrandingService field + DI ctor param + optional test ctor param + branding in ExportHtmlAsync

## Decisions Made

- Test constructors on the 3 ViewModels that had them (PermissionsViewModel, StorageViewModel, UserAccessAuditViewModel) received `IBrandingService? brandingService = null` as last optional parameter — this preserves all existing test instantiation call sites without any modification
- Guard clause `if (_brandingService is not null)` chosen over `null!` assignment — cleaner null-safety contract, makes graceful degradation explicit
- No new App.xaml.cs registrations needed — IBrandingService was already registered as singleton in Phase 10, and ViewModel registrations use constructor auto-resolution

## Deviations from Plan

None - plan executed exactly as written.

## Issues Encountered

A spurious test failure appeared during the stash/unstash verification step (`StorageViewModelChartTests.After_setting_metrics_BarChartSeries_has_one_ColumnSeries_with_matching_values`). This was a stale test binary issue, not a real failure — the test passed on both fresh runs before and after my changes. After proper rebuild, all 254 tests pass.

## User Setup Required

None.

## Next Phase Readiness

- All 5 export ViewModels now assemble `ReportBranding` from `IBrandingService.GetMspLogoAsync()` and `_currentProfile.ClientLogo` and pass it to WriteAsync
- When MSP and/or client logos are configured, HTML exports will include the branding header automatically
- Phase 11 is now functionally complete (Plans 01-03 done; 11-04 was SettingsViewModel which prior context indicates was already done)
- Build: 0 warnings, 0 errors; test suite: 254 passed / 0 failed / 26 skipped (skips are pre-existing integration tests)

---
*Phase: 11-html-export-branding*
*Completed: 2026-04-08*