kawa/Sharepoint-Toolbox
1
0
Fork 0
Code Issues Pull Requests Actions Releases 9 Wiki Activity

chore: archive v1.1 Enhanced Reports milestone
Some checks failed
Release SharePoint Toolbox v2 / release (push) Failing after 14s
Details

Browse Source 
v1.1 shipped with 4 phases (25 plans), 10/10 requirements complete:
- Global site selection (toolbar picker, all tabs consume)
- User access audit (Graph people-picker, direct/group/inherited)
- Simplified permissions (plain-language labels, risk levels, detail toggle)
- Storage visualization (LiveCharts2 pie/donut + bar charts)

Post-phase polish: centralized site selection (removed per-tab pickers),
claims prefix stripping, StorageMetrics backfill, chart tooltip fix,
summary stats in app + HTML exports.

205 tests passing, 10,484 LOC.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Dev
2026-04-08 10:21:02 +02:00
parent fa793c5489
commit fd442f3b4c
35 changed files with 1062 additions and 760 deletions
Download Patch File Download Diff File Expand all files Collapse all files

110
.planning/phases/08-simplified-permissions/VERIFICATION.md Normal file
View File

@@ -0,0 +1,110 @@
---
phase: 08-simplified-permissions
verified: 2026-04-07T14:30:00Z
status: passed
score: 4/4 must-haves verified
re_verification: false
---
# Phase 8: Simplified Permissions Verification Report
**Phase Goal:** Permissions reports are readable by non-technical users through plain-language labels, color coding, and a configurable detail level
**Verified:** 2026-04-07T14:30:00Z
**Status:** PASSED
**Re-verification:** No -- initial verification
## Goal Achievement
### Observable Truths (Success Criteria)
| # | Truth | Status | Evidence |
|---|-------|--------|----------|
| 1 | The permissions report displays human-readable labels (e.g., "Can edit files") alongside or instead of raw SharePoint role names when the simplified mode toggle is on | VERIFIED | `PermissionLevelMapping.cs` maps 11 standard SP roles to plain-language labels (e.g., "Contribute" -> "Can edit files and list items"). `SimplifiedPermissionEntry` wraps `PermissionEntry` with computed `SimplifiedLabels`. `PermissionsView.xaml` has a "Simplified" DataGrid column (line 254) bound to `SimplifiedLabels`, visible only when `IsSimplifiedMode=True`. ViewModel `OnIsSimplifiedModeChanged` calls `RebuildSimplifiedData()` which populates `SimplifiedResults`. Test `IsSimplifiedMode_WhenToggled_RebuildsSimplifiedResults` confirms. |
| 2 | The report shows summary counts per permission level with color indicators distinguishing high, medium, and low access levels | VERIFIED | `PermissionSummaryBuilder.Build()` groups entries by `RiskLevel` and returns 4 `PermissionSummary` records with `Count` and `DistinctUsers`. `PermissionsView.xaml` lines 143-201 render an `ItemsControl` bound to `Summaries` with `DataTrigger`s that apply distinct background colors per risk level: High=#FEE2E2 (red), Medium=#FEF3C7 (amber), Low=#D1FAE5 (green), ReadOnly=#DBEAFE (blue). DataGrid rows are also color-coded via `RowStyle` DataTriggers (lines 226-243). Tests `Build_ReturnsAllFourRiskLevels` and `Summaries_ContainsCorrectRiskBreakdown` confirm. |
| 3 | A detail-level selector (simple / detailed) controls whether individual item-level rows are shown or collapsed into summary rows | VERIFIED | `PermissionsView.xaml` lines 89-96 have two RadioButtons ("Simple (summary only)" / "Detailed (all rows)") bound to `IsDetailView` via `InvertBoolConverter`. DataGrid has a `MultiDataTrigger` (lines 214-220) that collapses the grid when `IsSimplifiedMode=True AND IsDetailView=False`, showing only summary cards. Test `IsDetailView_Toggle_DoesNotChangeCounts` confirms toggle does not re-compute data. |
| 4 | Toggling modes and detail level does not require re-running the scan -- it re-renders from the already-fetched data | VERIFIED | `OnIsSimplifiedModeChanged` calls `RebuildSimplifiedData()` which wraps the existing `Results` collection -- no service call. `OnIsDetailViewChanged` only fires `OnPropertyChanged(nameof(ActiveItemsSource))`. `ActiveItemsSource` is a computed property that returns `Results` or `SimplifiedResults` based on mode. Export services also branch on `IsSimplifiedMode` without re-scanning. Test `IsDetailView_Toggle_DoesNotChangeCounts` confirms counts remain stable across toggles. |
**Score:** 4/4 truths verified
### Required Artifacts
| Artifact | Expected | Status | Details |
|----------|----------|--------|---------|
| `SharepointToolbox/Core/Models/RiskLevel.cs` | Risk level enum (High, Medium, Low, ReadOnly) | VERIFIED | 4-value enum, 17 lines, well-documented |
| `SharepointToolbox/Core/Helpers/PermissionLevelMapping.cs` | Static mapping from SP role names to labels + risk | VERIFIED | 11 mappings, GetMapping/GetMappings/GetHighestRisk/GetSimplifiedLabels, case-insensitive, unknown->Medium fallback |
| `SharepointToolbox/Core/Models/SimplifiedPermissionEntry.cs` | Wrapper model with SimplifiedLabels + RiskLevel | VERIFIED | Wraps PermissionEntry via Inner, 9 passthrough properties, WrapAll factory |
| `SharepointToolbox/Core/Models/PermissionSummary.cs` | Summary record + builder | VERIFIED | PermissionSummary record + PermissionSummaryBuilder.Build returns all 4 risk levels |
| `SharepointToolbox/ViewModels/Tabs/PermissionsViewModel.cs` | IsSimplifiedMode, IsDetailView, SimplifiedResults, Summaries, ActiveItemsSource, RebuildSimplifiedData | VERIFIED | All properties present. Toggle handlers wired. Export branches for simplified mode. |
| `SharepointToolbox/Views/Tabs/PermissionsView.xaml` | Toggle controls, summary panel, color-coded DataGrid | VERIFIED | Display Options GroupBox with checkbox + radio buttons, ItemsControl summary panel with color DataTriggers, DataGrid RowStyle with risk-level coloring, Simplified column visible in simplified mode |
| `SharepointToolbox/Services/Export/CsvExportService.cs` | Simplified overload with SimplifiedLabels + RiskLevel columns | VERIFIED | BuildCsv(IReadOnlyList<SimplifiedPermissionEntry>) adds SimplifiedLabels and RiskLevel columns |
| `SharepointToolbox/Services/Export/HtmlExportService.cs` | Simplified overload with risk cards and color-coded rows | VERIFIED | BuildHtml(IReadOnlyList<SimplifiedPermissionEntry>) adds risk-card summary section, risk-badge per row, Simplified column |
| `SharepointToolbox/Core/Converters/InvertBoolConverter.cs` | Bool inverter for radio button binding | VERIFIED | IValueConverter, Convert and ConvertBack both invert |
| `SharepointToolbox/Localization/Strings.resx` | New keys: chk.simplified.mode, grp.display.opts, lbl.detail.level, rad.detail.simple, rad.detail.detailed, lbl.summary.users | VERIFIED | All 6 keys present in EN |
| `SharepointToolbox/Localization/Strings.fr.resx` | French translations for new keys | VERIFIED | All 6 keys present in FR |
| `SharepointToolbox.Tests/Helpers/PermissionLevelMappingTests.cs` | Tests for mapping correctness | VERIFIED | 8 test methods covering known roles (11 InlineData), unknown fallback, case insensitivity, semicolon split, risk ranking, labels |
| `SharepointToolbox.Tests/Models/PermissionSummaryBuilderTests.cs` | Tests for summary builder | VERIFIED | 4 test methods: all 4 risk levels, empty collection, distinct users, WrapAll preserves Inner |
| `SharepointToolbox.Tests/ViewModels/PermissionsViewModelTests.cs` | Simplified mode tests | VERIFIED | 4 new tests: default false, toggle rebuilds, detail toggle no-op, risk breakdown |
### Key Link Verification
| From | To | Via | Status | Details |
|------|----|-----|--------|---------|
| SimplifiedPermissionEntry | PermissionLevelMapping | `PermissionLevelMapping.GetMappings/GetSimplifiedLabels/GetHighestRisk` | WIRED | Constructor calls all three mapping methods (lines 48-50) |
| SimplifiedPermissionEntry | PermissionEntry | `Inner` property | WIRED | Constructor stores entry as `Inner`, 9 passthrough properties delegate to `Inner` |
| PermissionsViewModel | SimplifiedPermissionEntry | `SimplifiedPermissionEntry.WrapAll(Results)` in `RebuildSimplifiedData` | WIRED | Line 234 |
| PermissionsViewModel | PermissionSummaryBuilder | `PermissionSummaryBuilder.Build(SimplifiedResults)` in `RebuildSimplifiedData` | WIRED | Line 235 |
| PermissionsView.xaml | PermissionsViewModel | DataGrid binds `ActiveItemsSource`, summary binds `Summaries`, toggles bind `IsSimplifiedMode`/`IsDetailView` | WIRED | XAML bindings at lines 72-96 (toggles), 143 (Summaries), 205 (ActiveItemsSource) |
| CsvExportService | SimplifiedPermissionEntry | Overloaded `BuildCsv`/`WriteAsync` | WIRED | ViewModel calls simplified overload when `IsSimplifiedMode && SimplifiedResults.Count > 0` (line 346) |
| HtmlExportService | SimplifiedPermissionEntry | Overloaded `BuildHtml`/`WriteAsync` | WIRED | ViewModel calls simplified overload when `IsSimplifiedMode && SimplifiedResults.Count > 0` (line 372) |
### Requirements Coverage
| Requirement | Description | Status | Evidence |
|-------------|-------------|--------|----------|
| SIMP-01 | User can toggle plain-language permission labels | SATISFIED | PermissionLevelMapping + SimplifiedPermissionEntry + IsSimplifiedMode toggle + Simplified column in DataGrid |
| SIMP-02 | Permissions report includes summary counts and color coding | SATISFIED | PermissionSummaryBuilder + summary ItemsControl with color DataTriggers + DataGrid RowStyle coloring + HTML risk cards |
| SIMP-03 | User can choose detail level (simple/detailed) for reports | SATISFIED | IsDetailView radio buttons + MultiDataTrigger hides DataGrid in simple mode + summary-only display |
No orphaned requirements found for Phase 8.
### Anti-Patterns Found
| File | Line | Pattern | Severity | Impact |
|------|------|---------|----------|--------|
| (none) | - | - | - | No TODO, FIXME, placeholder, or stub patterns found in any Phase 8 file |
### Build and Test Results
- **Main project build:** 0 errors, 9 warnings (all pre-existing NuGet compatibility warnings)
- **Test project build:** 0 errors, 12 warnings (same NuGet warnings)
- **Targeted tests:** 27 passed, 0 failed (PermissionLevelMappingTests + PermissionSummaryBuilderTests + PermissionsViewModelTests)
- **PermissionEntry.cs:** Confirmed unmodified (git diff empty)
### Human Verification Required
### 1. Simplified Mode Visual Toggle
**Test:** Run the app, scan a site's permissions, then check the "Simplified mode" checkbox.
**Expected:** The "Simplified" column appears in the DataGrid showing labels like "Can edit files and list items" next to raw "Contribute". Summary cards appear above the grid with colored backgrounds (red for High, amber for Medium, green for Low, blue for ReadOnly) and correct counts.
**Why human:** Visual layout, color rendering, and DataGrid column sizing cannot be verified programmatically.
### 2. Detail Level Switching
**Test:** With simplified mode on, click "Simple (summary only)" radio button, then "Detailed (all rows)".
**Expected:** In simple mode, the DataGrid hides and only summary cards are visible. In detailed mode, the DataGrid reappears with all rows. No loading indicator or delay -- instant re-render.
**Why human:** Visual collapse/expand behavior and perceived latency require human observation.
### 3. Export in Simplified Mode
**Test:** With simplified mode on, export to CSV and HTML. Open both files.
**Expected:** CSV includes "SimplifiedLabels" and "RiskLevel" columns. HTML includes risk-level colored summary cards at the top and a "Simplified" + "Risk" column in the table with colored badges.
**Why human:** File content rendering and visual appearance of HTML export need manual inspection.
### Gaps Summary
No gaps found. All 4 success criteria are verified through code inspection, build confirmation, and passing unit tests. The implementation is complete: data models, mapping layer, ViewModel logic, XAML UI with color-coded summary panel and detail toggle, export service overloads, localization in EN and FR, and comprehensive unit test coverage.
---
_Verified: 2026-04-07T14:30:00Z_
_Verifier: Claude (gsd-verifier)_