fix(01-foundation): revise plans based on checker feedback

- 01-04: wave 3 → 4 (01-03 is also wave 3; parallel executor would race) - 01-06: wave 4 → 5 (cascades from 01-04 fix); add FeatureTabBase UserControl for per-tab progress/cancel strip; bind StatusBar middle item to ProgressStatus instead of ConnectionStatus per locked CONTEXT.md decision - 01-07: wave 5 → 6 (cascades) - 01-08: wave 6 → 7 (cascades) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-02 11:53:41 +02:00
parent eeb9a3bcd1
commit b4a901e52a
4 changed files with 120 additions and 25 deletions
--- a/.planning/phases/01-foundation/01-06-PLAN.md
+++ b/.planning/phases/01-foundation/01-06-PLAN.md
@@ -2,7 +2,7 @@
 phase: 01-foundation
 plan: 06
 type: execute
-wave: 4
+wave: 5
 depends_on:
  - 01-03
  - 01-04
@@ -13,6 +13,8 @@ files_modified:
  - SharepointToolbox/ViewModels/MainWindowViewModel.cs
  - SharepointToolbox/ViewModels/ProfileManagementViewModel.cs
  - SharepointToolbox/ViewModels/Tabs/SettingsViewModel.cs
+  - SharepointToolbox/Views/Controls/FeatureTabBase.xaml
+  - SharepointToolbox/Views/Controls/FeatureTabBase.xaml.cs
  - SharepointToolbox/Views/MainWindow.xaml
  - SharepointToolbox/Views/MainWindow.xaml.cs
  - SharepointToolbox/App.xaml.cs
@@ -31,6 +33,8 @@ must_haves:
    - "Global exception handlers (DispatcherUnhandledException + TaskScheduler.UnobservedTaskException) funnel to log panel + MessageBox"
    - "LogPanelSink wired to MainWindow RichTextBox after Generic Host starts"
    - "FeatureViewModelBaseTests: progress reporting, cancellation, and error handling all green"
+    - "All 7 stub feature tabs use FeatureTabBase UserControl — ProgressBar + TextBlock + Cancel button shown only when IsRunning"
+    - "StatusBar middle item shows live operation status text (ProgressStatus from ProgressUpdatedMessage), not static ConnectionStatus"
  artifacts:
    - path: "SharepointToolbox/ViewModels/FeatureViewModelBase.cs"
      provides: "Base class for all feature ViewModels with canonical async command pattern"
@@ -38,6 +42,9 @@ must_haves:
    - path: "SharepointToolbox/ViewModels/MainWindowViewModel.cs"
      provides: "Shell ViewModel with TenantProfiles and connection state"
      contains: "ObservableCollection"
+    - path: "SharepointToolbox/Views/Controls/FeatureTabBase.xaml"
+      provides: "Reusable UserControl with ProgressBar + TextBlock + Cancel button strip"
+      contains: "ProgressBar"
    - path: "SharepointToolbox/Views/MainWindow.xaml"
      provides: "WPF shell with toolbar, TabControl, log panel, StatusBar"
      contains: "RichTextBox"
@@ -56,15 +63,23 @@ must_haves:
      pattern: "TenantSwitchedMessage"
    - from: "SharepointToolbox/ViewModels/MainWindowViewModel.cs"
      to: "SharepointToolbox/Core/Messages/ProgressUpdatedMessage.cs"
-      via: "Messenger.Register<ProgressUpdatedMessage> in OnActivated — updates StatusBar observable properties"
+      via: "Messenger.Register<ProgressUpdatedMessage> in OnActivated — updates ProgressStatus + ProgressPercentage"
      pattern: "ProgressUpdatedMessage"
+    - from: "SharepointToolbox/Views/MainWindow.xaml StatusBar middle item"
+      to: "SharepointToolbox/ViewModels/MainWindowViewModel.cs ProgressStatus"
+      via: "Binding Content={Binding ProgressStatus}"
+      pattern: "ProgressStatus"
+    - from: "SharepointToolbox/Views/MainWindow.xaml stub TabItems"
+      to: "SharepointToolbox/Views/Controls/FeatureTabBase.xaml"
+      via: "TabItem Content contains <controls:FeatureTabBase />"
+      pattern: "FeatureTabBase"
 ---

 <objective>
-Build the WPF shell — MainWindow XAML + all ViewModels. Wire LogPanelSink to the RichTextBox. Implement FeatureViewModelBase with the canonical async pattern. Register global exception handlers.
+Build the WPF shell — MainWindow XAML + all ViewModels. Wire LogPanelSink to the RichTextBox. Implement FeatureViewModelBase with the canonical async pattern. Create FeatureTabBase UserControl (per-tab progress/cancel strip). Register global exception handlers.

-Purpose: This is the first time the application visually exists. All subsequent feature plans add TabItems to the already-wired TabControl.
-Output: Runnable WPF application showing the shell with placeholder tabs, log panel, and status bar.
+Purpose: This is the first time the application visually exists. All subsequent feature plans add TabItems to the already-wired TabControl. FeatureTabBase gives Phase 2+ a XAML template to extend rather than stub TextBlocks.
+Output: Runnable WPF application showing the shell with placeholder tabs (using FeatureTabBase), log panel, and status bar with live operation text.
 </objective>

 <execution_context>
@@ -109,7 +124,8 @@ public sealed class LanguageChangedMessage : ValueChangedMessage<string>
 // Toolbar (L→R): ComboBox (220px) → Button "Connect" → Button "Manage Profiles..." → separator → Button "Clear Session"
 // TabControl: 8 tabs (Permissions, Storage, File Search, Duplicates, Templates, Bulk Operations, Folder Structure, Settings)
 // Log panel: RichTextBox, 150px tall, always visible, x:Name="LogPanel"
-// StatusBar: tenant name | operation status | progress %
+// StatusBar: tenant name | operation status text | progress %
+// Per-tab layout: ProgressBar + TextBlock + Button "Cancel" — shown only when IsRunning (CONTEXT.md Gray Areas, locked)
 </interfaces>
 </context>

@@ -238,8 +254,10 @@ public sealed class LanguageChangedMessage : ValueChangedMessage<string>
 </task>

 <task type="auto">
-  <name>Task 2: MainWindowViewModel, shell ViewModels, and MainWindow XAML</name>
+  <name>Task 2: FeatureTabBase UserControl, MainWindowViewModel, shell ViewModels, and MainWindow XAML</name>
  <files>
+    SharepointToolbox/Views/Controls/FeatureTabBase.xaml,
+    SharepointToolbox/Views/Controls/FeatureTabBase.xaml.cs,
    SharepointToolbox/ViewModels/MainWindowViewModel.cs,
    SharepointToolbox/ViewModels/ProfileManagementViewModel.cs,
    SharepointToolbox/ViewModels/Tabs/SettingsViewModel.cs,
@@ -248,7 +266,53 @@ public sealed class LanguageChangedMessage : ValueChangedMessage<string>
    SharepointToolbox/App.xaml.cs
  </files>
  <action>
-    Create `ViewModels/Tabs/` and `Views/` directories.
+    Create `Views/Controls/`, `ViewModels/Tabs/`, and `Views/` directories.
+
+    **FeatureTabBase.xaml** — UserControl that every stub feature tab uses as its Content.
+    This gives Phase 2+ a concrete XAML template to replace rather than a bare TextBlock.
+    The progress/cancel strip is Visibility-bound to IsRunning per the locked CONTEXT.md decision.
+
+    ```xml
+    <UserControl x:Class="SharepointToolbox.Views.Controls.FeatureTabBase"
+                 xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
+                 xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml">
+      <Grid>
+        <Grid.RowDefinitions>
+          <RowDefinition Height="*" />       <!-- Feature content area (Phase 2+ replaces this) -->
+          <RowDefinition Height="Auto" />    <!-- Progress/cancel strip -->
+        </Grid.RowDefinitions>
+
+        <!-- Placeholder content — Phase 2+ replaces Row 0 -->
+        <TextBlock Grid.Row="0"
+                   Text="{Binding Source={x:Static loc:TranslationSource.Instance}, Path=[tab.comingsoon]}"
+                   HorizontalAlignment="Center" VerticalAlignment="Center" />
+
+        <!-- Per-tab progress/cancel strip (locked CONTEXT.md: shown only when IsRunning) -->
+        <Grid Grid.Row="1" Margin="8,4"
+              Visibility="{Binding IsRunning, Converter={StaticResource BoolToVisibilityConverter}}">
+          <Grid.ColumnDefinitions>
+            <ColumnDefinition Width="*" />
+            <ColumnDefinition Width="Auto" />
+            <ColumnDefinition Width="Auto" />
+          </Grid.ColumnDefinitions>
+          <ProgressBar Grid.Column="0" Height="16" Minimum="0" Maximum="100"
+                       Value="{Binding ProgressValue}" />
+          <TextBlock Grid.Column="1" Margin="8,0" VerticalAlignment="Center"
+                     Text="{Binding StatusMessage}" />
+          <Button Grid.Column="2"
+                  Content="{Binding Source={x:Static loc:TranslationSource.Instance}, Path=[btn.cancel]}"
+                  Command="{Binding CancelCommand}" Width="70" />
+        </Grid>
+      </Grid>
+    </UserControl>
+    ```
+
+    **FeatureTabBase.xaml.cs**: Standard code-behind with no extra logic (DataContext is set by the parent TabItem's DataContext chain).
+
+    Add `BoolToVisibilityConverter` to App.xaml resources if not already present:
+    ```xml
+    <BooleanToVisibilityConverter x:Key="BoolToVisibilityConverter" />
+    ```

    **MainWindowViewModel.cs**:
    ```csharp
@@ -294,7 +358,13 @@ public sealed class LanguageChangedMessage : ValueChangedMessage<string>
    - `RunOperationAsync`: not applicable — stub throws `NotSupportedException` (Settings tab has no long-running operation)

    **MainWindow.xaml** — Full shell layout as locked in CONTEXT.md.
-    StatusBar MUST have three fields per the locked decision (tenant name | operation status text | progress percentage):
+
+    StatusBar middle item MUST bind to `ProgressStatus` (live operation text from ProgressUpdatedMessage),
+    NOT `ConnectionStatus`. Per locked CONTEXT.md: "operation status text" means the live progress text.
+
+    The 7 stub feature tabs MUST use `<controls:FeatureTabBase />` as their Content,
+    NOT bare TextBlocks. This gives Phase 2 a XAML template to extend.
+
    ```xml
    <Window Title="{Binding Source={x:Static loc:TranslationSource.Instance}, Path=[app.title]}"
            MinWidth="900" MinHeight="600">
@@ -313,11 +383,12 @@ public sealed class LanguageChangedMessage : ValueChangedMessage<string>
                  Command="{Binding ClearSessionCommand}" />
        </ToolBar>

-        <!-- StatusBar: three fields per locked layout decision -->
+        <!-- StatusBar: three fields per locked layout decision.
+             Middle field binds to ProgressStatus (live operation text), NOT ConnectionStatus. -->
        <StatusBar DockPanel.Dock="Bottom" Height="24">
          <StatusBarItem Content="{Binding SelectedProfile.Name}" />
          <Separator />
-          <StatusBarItem Content="{Binding ConnectionStatus}" />
+          <StatusBarItem Content="{Binding ProgressStatus}" />
          <Separator />
          <StatusBarItem Content="{Binding ProgressPercentage, StringFormat={}{0}%}" />
        </StatusBar>
@@ -328,15 +399,32 @@ public sealed class LanguageChangedMessage : ValueChangedMessage<string>
                     Background="Black" Foreground="LimeGreen"
                     FontFamily="Consolas" FontSize="11" />

-        <!-- TabControl -->
+        <!-- TabControl: 7 stub tabs use FeatureTabBase; Settings tab wired in plan 01-07 -->
        <TabControl>
          <TabItem Header="{Binding Source={x:Static loc:TranslationSource.Instance}, Path=[tab.permissions]}">
-            <TextBlock Text="{Binding Source={x:Static loc:TranslationSource.Instance}, Path=[tab.comingsoon]}"
-                       HorizontalAlignment="Center" VerticalAlignment="Center" />
+            <controls:FeatureTabBase />
          </TabItem>
-          <!-- Repeat for: Storage, File Search, Duplicates, Templates, Bulk Operations, Folder Structure -->
-          <!-- Settings tab binds to SettingsView (plan 01-07) -->
-          <TabItem Header="{Binding Source={x:Static loc:TranslationSource.Instance}, Path=[tab.settings]}">
+          <TabItem Header="{Binding Source={x:Static loc:TranslationSource.Instance}, Path=[tab.storage]}">
+            <controls:FeatureTabBase />
+          </TabItem>
+          <TabItem Header="{Binding Source={x:Static loc:TranslationSource.Instance}, Path=[tab.filesearch]}">
+            <controls:FeatureTabBase />
+          </TabItem>
+          <TabItem Header="{Binding Source={x:Static loc:TranslationSource.Instance}, Path=[tab.duplicates]}">
+            <controls:FeatureTabBase />
+          </TabItem>
+          <TabItem Header="{Binding Source={x:Static loc:TranslationSource.Instance}, Path=[tab.templates]}">
+            <controls:FeatureTabBase />
+          </TabItem>
+          <TabItem Header="{Binding Source={x:Static loc:TranslationSource.Instance}, Path=[tab.bulk]}">
+            <controls:FeatureTabBase />
+          </TabItem>
+          <TabItem Header="{Binding Source={x:Static loc:TranslationSource.Instance}, Path=[tab.folderstructure]}">
+            <controls:FeatureTabBase />
+          </TabItem>
+          <!-- Settings tab: placeholder TextBlock replaced by SettingsView in plan 01-07 -->
+          <TabItem x:Name="SettingsTabItem"
+                   Header="{Binding Source={x:Static loc:TranslationSource.Instance}, Path=[tab.settings]}">
            <TextBlock Text="Settings (plan 01-07)" HorizontalAlignment="Center" VerticalAlignment="Center" />
          </TabItem>
        </TabControl>
@@ -344,6 +432,9 @@ public sealed class LanguageChangedMessage : ValueChangedMessage<string>
    </Window>
    ```

+    Add namespace in Window opening tag:
+    `xmlns:controls="clr-namespace:SharepointToolbox.Views.Controls"`
+
    **MainWindow.xaml.cs**: Constructor receives `MainWindowViewModel` via DI constructor injection. Sets `DataContext = viewModel`. Calls `viewModel.LoadProfilesAsync()` in `Loaded` event.

    **App.xaml.cs** — Update RegisterServices:
@@ -397,7 +488,7 @@ public sealed class LanguageChangedMessage : ValueChangedMessage<string>
  <verify>
    <automated>cd "C:\Users\dev\Documents\projets\Sharepoint" && dotnet build SharepointToolbox/SharepointToolbox.csproj 2>&1 | tail -5</automated>
  </verify>
-  <done>Build succeeds with 0 errors. MainWindow.xaml contains RichTextBox x:Name="LogPanel". StatusBar has three StatusBarItems (tenant name, connection status, progress %). All 8 tab headers use TranslationSource bindings. Global exception handlers registered in App.xaml.cs.</done>
+  <done>Build succeeds with 0 errors. MainWindow.xaml contains RichTextBox x:Name="LogPanel". StatusBar middle StatusBarItem binds to ProgressStatus (not ConnectionStatus). All 7 stub feature TabItems contain &lt;controls:FeatureTabBase /&gt; (not bare TextBlocks). Settings TabItem has x:Name="SettingsTabItem". All 8 tab headers use TranslationSource bindings. Global exception handlers registered in App.xaml.cs.</done>
 </task>

 </tasks>
@@ -406,7 +497,9 @@ public sealed class LanguageChangedMessage : ValueChangedMessage<string>
 - `dotnet build SharepointToolbox.sln` passes with 0 errors
 - `dotnet test --filter "Category=Unit"` all pass
 - MainWindow.xaml contains `x:Name="LogPanel"` RichTextBox
- MainWindow.xaml StatusBar has three StatusBarItems: SelectedProfile.Name | ConnectionStatus | ProgressPercentage%
+- MainWindow.xaml StatusBar middle StatusBarItem binds to `ProgressStatus` (live operation text)
+- MainWindow.xaml 7 stub TabItems contain `controls:FeatureTabBase` (not TextBlocks)
+- FeatureTabBase.xaml contains ProgressBar + TextBlock + Button with Visibility bound to IsRunning
 - App.xaml.cs registers `DispatcherUnhandledException` and `TaskScheduler.UnobservedTaskException`
 - FeatureViewModelBase contains no `async void` methods (anti-pattern violation)
 - ObservableCollection is never modified from Task.Run (pattern 7 compliance)
@@ -414,7 +507,7 @@ public sealed class LanguageChangedMessage : ValueChangedMessage<string>
 </verification>

 <success_criteria>
-Application compiles and launches to a visible WPF shell. FeatureViewModelBase tests green. All ViewModels registered in DI. Log panel wired to Serilog. StatusBar shows all three fields including live progress percentage.
+Application compiles and launches to a visible WPF shell. FeatureViewModelBase tests green. All ViewModels registered in DI. Log panel wired to Serilog. StatusBar middle field shows live operation status text (ProgressStatus). All 7 stub feature tabs include the progress/cancel strip template via FeatureTabBase.
 </success_criteria>

 <output>