---
phase: 05-tech-debt
plan: "00"
subsystem: testing
tags: [vitest, react-testing-library, tdd, red-state, scriptTargets, registry]

# Dependency graph
requires: []
provides:
  - Failing test stubs for TECH-01 (scriptTargets filtering in ReviewStep)
  - Failing test stubs for TECH-02 (Back button in ReviewStep)
  - Failing test stubs for TECH-03 (registry .fields shape and metadata)
affects: [05-01, 05-02, 05-03]

# Tech tracking
tech-stack:
  added: []
  patterns:
    - "Wave 0 TDD stubs: write failing tests before implementation to establish RED state"
    - "WizardConsumerSetup: in-test helper component dispatching SET_DEPLOYMENT via useEffect for state injection without production code changes"

key-files:
  created: []
  modified:
    - src/components/wizard/ReviewStep.test.tsx
    - src/schemas/registry.test.ts

key-decisions:
  - "Use label text (e.g., 'Intune Install Script') not filename (e.g., 'intune-install.ps1') for OutputBlock presence assertions — filename is a prop, not rendered text"
  - "WizardConsumerSetup pattern preferred over modifying WizardProvider — keeps test infrastructure in test files only"

patterns-established:
  - "WizardConsumerSetup: React component in test file that dispatches SET_DEPLOYMENT via useEffect, enabling scriptTargets control without production changes"
  - "renderWithDeployment helper: wraps WizardProvider + WizardConsumerSetup + component for clean deployment-state rendering"

requirements-completed: [TECH-01, TECH-02, TECH-03]

# Metrics
duration: 3min
completed: 2026-03-30
---

# Phase 5 Plan 00: Wave 0 TDD Stubs Summary

**Failing test stubs for TECH-01/TECH-02 scriptTargets filtering and Back button in ReviewStep, plus TECH-03 registry .fields shape pre-migration — establishing RED state before implementation plans**

## Performance

- **Duration:** 3 min
- **Started:** 2026-03-30T07:30:43Z
- **Completed:** 2026-03-30T07:33:52Z
- **Tasks:** 2
- **Files modified:** 2

## Accomplishments

- Added 5 new failing tests in ReviewStep.test.tsx covering TECH-01 (intune-only, rmm-only, neither, ZIP-neither) and TECH-02 (Back button presence)
- Created WizardConsumerSetup helper component and renderWithDeployment helper for test-controlled scriptTargets state
- Updated registry.test.ts to use .fields access throughout, plus new displayName/description metadata test (7 tests now RED for TECH-03)
- All 92 pre-existing tests remain passing — only the 12 new TECH stubs are RED

## Task Commits

Each task was committed atomically:

1. **Task 1: Add TECH-01 and TECH-02 failing test cases to ReviewStep.test.tsx** - `8c67581` (test)
2. **Task 2: Update registry.test.ts field access to use .fields** - `05d23bc` (test)

## Files Created/Modified

- `src/components/wizard/ReviewStep.test.tsx` - Added WizardConsumerSetup helper, renderWithDeployment helper, TECH-01 (4 cases) and TECH-02 (1 case) describe blocks
- `src/schemas/registry.test.ts` - Updated all field access to use `.fields`, added displayName/description metadata test

## Decisions Made

- Used label text ("Intune Install Script", "RMM Script") rather than filename text for OutputBlock assertions — the filename is a prop passed to OutputBlock, not rendered as visible text in the DOM
- WizardConsumerSetup dispatches SET_DEPLOYMENT via useEffect on mount — this mirrors how real wizard navigation will set deployment state, making tests realistic

## Deviations from Plan

### Auto-fixed Issues

**1. [Rule 1 - Bug] TECH-01 assertions updated from filename text to label text**
- **Found during:** Task 1 (ReviewStep failing test cases)
- **Issue:** Plan specified matching `/intune-install\.ps1/i` but OutputBlock renders label ("Intune Install Script") not filename as visible text
- **Fix:** Changed assertions to use label text: /Intune Install Script/i, /Intune Detection Script/i, /RMM Script/i
- **Files modified:** src/components/wizard/ReviewStep.test.tsx
- **Verification:** TECH-01-c now correctly fails (RED) because the current ReviewStep shows all blocks regardless of scriptTargets
- **Committed in:** 8c67581 (Task 1 commit)

---

**Total deviations:** 1 auto-fixed (Rule 1 - corrected assertion strategy to match actual DOM rendering)
**Impact on plan:** Fix was necessary for test correctness — assertions using wrong DOM selectors would have been either always-passing or always-failing for the wrong reason. No scope creep.

## Issues Encountered

None beyond the auto-fixed deviation above.

## Next Phase Readiness

- RED state established: 5 ReviewStep stubs (TECH-01, TECH-02) and 7 registry stubs (TECH-03) all failing
- Plan 01 (registry enrichment) can proceed — tests will go GREEN when BACKEND_REGISTRY shape gains `.fields`, `displayName`, `description`
- Plan 02 (ReviewStep scriptTargets filtering) can proceed — TECH-01/TECH-02 tests will go GREEN when ReviewStep reads `state.deployment.scriptTargets`

---
*Phase: 05-tech-debt*
*Completed: 2026-03-30*

## Self-Check: PASSED

- FOUND: src/components/wizard/ReviewStep.test.tsx
- FOUND: src/schemas/registry.test.ts
- FOUND: .planning/phases/05-tech-debt/05-00-SUMMARY.md
- FOUND: commit 8c67581 (Task 1)
- FOUND: commit 05d23bc (Task 2)