chore: archive v1.0 milestone — MVP shipped

4 phases, 18 plans, 24/24 requirements, 98 tests GREEN. Archived ROADMAP + REQUIREMENTS to milestones/. ROADMAP collapsed. PROJECT.md evolved with validated requirements and key decisions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-03-27 15:36:40 +01:00
parent 2d5f8f4a81
commit ef0cd94eb7
8 changed files with 457 additions and 121 deletions
@@ -0,0 +1,192 @@
+---
+milestone: v1.0
+audited: 2026-03-27T16:00:00Z
+status: tech_debt
+scores:
+  requirements: 24/24
+  phases: 4/4
+  integration: 20/24
+  flows: 5/5
+gaps: {}
+tech_debt:
+  - phase: 04-review-download-security
+    items:
+      - "scriptTargets field (DeploymentStep) collected but never consumed by ReviewStep — all 4 output blocks always render unconditionally regardless of Intune/RMM selection. Affects: DEPL-01, DEPL-02, DEPL-03, DOWN-02, DOWN-03, DOWN-04, DOWN-05 (misleading UX but no explicit v1 requirement violated)."
+      - "ReviewStep has no Back button — users must navigate back via StepIndicator breadcrumb only. All other step components have explicit Back buttons (UX inconsistency)."
+      - "6 human verification items pending browser confirmation: CONF-02 live preview reactivity, SECU-01 visual disabled styling, DOWN-01–04 real file writes, DOWN-05 ZIP archive content, CONF-03/DOWN-06 clipboard paste, SECU-03 DevTools storage check."
+  - phase: 01-foundation
+    items:
+      - "BackendFormValues<T> utility type (src/schemas/index.ts line 27) exported but never imported anywhere in production code — dead code from day 1."
+  - phase: 03-wizard-ui
+    items:
+      - "act() warnings in BackendSelectionStep tests — async state updates not fully wrapped in act(). Tests pass but test hygiene issue."
+      - "Backend selection list in BackendSelectionStep.tsx is a hardcoded BACKENDS constant, not driven by BACKEND_REGISTRY keys. Adding a backend to the registry does not automatically surface it in the UI — maintainability gap."
+nyquist:
+  compliant_phases: []
+  partial_phases:
+    - 01-foundation
+    - 02-generators
+    - 03-wizard-ui
+    - 04-review-download-security
+  missing_phases: []
+  overall: partial
+---
+
+# v1.0 Milestone Audit — Ready2Blob
+
+**Audited:** 2026-03-27T16:00:00Z
+**Status:** TECH_DEBT — all 24 requirements satisfied, no critical blockers, accumulated deferred items need review
+**Milestone:** v1.0 — Full wizard: foundation → generators → wizard UI → review/download/security
+
+---
+
+## Score Summary
+
+| Dimension | Score | Notes |
+|-----------|-------|-------|
+| Requirements | 24/24 | All v1 requirements satisfied (3-source verified) |
+| Phases | 4/4 | All phases passed verification |
+| Integration | 20/24 | scriptTargets disconnect affects 4 wiring paths |
+| E2E Flows | 5/5 | All flows complete end-to-end |
+
+---
+
+## Phase Verification Status
+
+| Phase | Status | Score | Human Items |
+|-------|--------|-------|-------------|
+| 01-foundation | PASSED | 12/12 | 1 (browser console errors — routine) |
+| 02-generators | PASSED | 17/17 | 0 |
+| 03-wizard-ui | PASSED | 6/6 | 4 (human-approved during execution) |
+| 04-review-download-security | human_needed | 11/11 automated | 6 pending browser confirmation |
+
+No phase is missing a VERIFICATION.md.
+
+---
+
+## Requirements Coverage (3-Source Cross-Reference)
+
+Cross-referenced against: (1) phase VERIFICATION.md status, (2) SUMMARY.md `requirements-completed` frontmatter, (3) REQUIREMENTS.md traceability table.
+
+| Req | Description | Phase | VERIFICATION | SUMMARY | REQUIREMENTS | Final |
+|-----|-------------|-------|-------------|---------|-------------|-------|
+| WIZD-01 | Backend selection, popularity-sorted | 3 | SATISFIED | 03-01 | [x] | **satisfied** |
+| WIZD-02 | Multi-step wizard navigation | 3 | SATISFIED | 03-01, 03-05 | [x] | **satisfied** |
+| WIZD-03 | Back navigation without data loss | 3 | SATISFIED | 03-01, 03-05 | [x] | **satisfied** |
+| WIZD-04 | Custom remote name with validation | 3 | SATISFIED | 03-01 | [x] | **satisfied** |
+| BACK-01 | Azure Blob remote config | 3 | SATISFIED | 03-01, 03-04 | [x] | **satisfied** |
+| BACK-02 | Amazon S3 remote config | 3 | SATISFIED | 03-01, 03-04 | [x] | **satisfied** |
+| BACK-03 | S3-compatible remote (endpoint override) | 3 | SATISFIED | 03-01, 03-04 | [x] | **satisfied** |
+| CONF-01 | Generate valid rclone.conf (INI) | 2 | SATISFIED | 02-01, 02-02 | [x] | **satisfied** |
+| CONF-02 | Live rclone.conf preview | 4 | SATISFIED | 04-01, 04-03–05 | [x] | **satisfied** |
+| CONF-03 | Copy rclone.conf to clipboard | 4 | SATISFIED | 04-01–05 | [x] | **satisfied** |
+| DEPL-01 | Intune PowerShell install script | 2 | SATISFIED | 02-01, 02-03 | [x] | **satisfied** |
+| DEPL-02 | Intune detection script | 2 | SATISFIED | 02-01, 02-03 | [x] | **satisfied** |
+| DEPL-03 | RMM PowerShell script | 2 | SATISFIED | 02-01, 02-04 | [x] | **satisfied** |
+| DEPL-04 | Toggle "Include rclone installation" | 2 | SATISFIED | 02-01, 02-03, 02-04 | [x] | **satisfied** |
+| DEPL-05 | Config deployment path choice | 2 | SATISFIED | 02-01, 02-03, 02-04 | [x] | **satisfied** |
+| DOWN-01 | Download rclone.conf individually | 4 | SATISFIED | 04-01–05 | [x] | **satisfied** |
+| DOWN-02 | Download Intune install individually | 4 | SATISFIED | 04-01–05 | [x] | **satisfied** |
+| DOWN-03 | Download Intune detection individually | 4 | SATISFIED | 04-01–05 | [x] | **satisfied** |
+| DOWN-04 | Download RMM script individually | 4 | SATISFIED | 04-01–05 | [x] | **satisfied** |
+| DOWN-05 | Download all as ZIP bundle | 4 | SATISFIED | 04-01–05 | [x] | **satisfied** |
+| DOWN-06 | Copy any output block to clipboard | 4 | SATISFIED | 04-01–05 | [x] | **satisfied** |
+| SECU-01 | Security warning gate before downloads | 4 | SATISFIED | 04-01, 04-03–05 | [x] | **satisfied** |
+| SECU-02 | "No data sent to server" notice | 4 | SATISFIED | 04-01, 04-03–05 | [x] | **satisfied** |
+| SECU-03 | No localStorage/sessionStorage writes | 4 | SATISFIED | 04-01, 04-04–05 | [x] | **satisfied** |
+
+**Orphaned requirements:** None. All 24 REQ-IDs present in REQUIREMENTS.md traceability table are claimed by phase plans and verified in VERIFICATION.md files.
+
+---
+
+## Cross-Phase Integration Report
+
+### E2E Flow Results
+
+| Flow | Verdict | Notes |
+|------|---------|-------|
+| 1. Select Azure Blob → fill config → deployment → live preview → acknowledge → download all | COMPLETE | End-to-end path works; scriptTargets caveat (see tech debt) |
+| 2. WizardState types → Phase 2 generators → Phase 4 output | COMPLETE | Type-safe; CONFIG_DIR locked to WizardState union literal |
+| 3. Config path consistency (ps-helpers.ts ↔ DeploymentStep) | COMPLETE | All 3 scripts use same CONFIG_DIR; 'machine-wide' and 'user-profile' keys match exactly |
+| 4. SECU-03 isolation (reducer → no storage writes) | COMPLETE | Pure reducer, no useEffect writes, 0 localStorage/sessionStorage calls in production code |
+| 5. Step count consistency (3 wizard steps + 1 review step) | COMPLETE | App.tsx steps[0..3], StepIndicator STEP_LABELS[0..3], clamp guard in place |
+
+### Integration Issues (Tech Debt — No Blockers)
+
+**TD-1: `scriptTargets` disconnected (affects DEPL-01/02/03, DOWN-02/03/04/05)**
+
+- `WizardState.deployment.scriptTargets: ('intune' | 'rmm')[]` is dispatched by `DeploymentStep.tsx` but never read by `ReviewStep.tsx`
+- All 4 `OutputBlock` components render unconditionally — user can uncheck Intune or RMM in DeploymentStep but all blocks still appear in ReviewStep
+- No v1 requirement explicitly mandates conditional output filtering by scriptTargets, so this does not violate any stated requirement
+- Fix location: `src/components/wizard/ReviewStep.tsx` — read `state.deployment.scriptTargets` and conditionally render/include each block
+- Severity: **UX misleading, not a requirement violation**
+
+**TD-2: ReviewStep missing Back button**
+
+- All other step components (BackendSelectionStep, RemoteConfigStep, DeploymentStep) have explicit Back buttons
+- WIZD-03 is satisfied through StepIndicator breadcrumb, but UX is inconsistent
+- Fix location: `src/components/wizard/ReviewStep.tsx` — add a Back button dispatching `SET_STEP(2)`
+
+**TD-3: `BackendFormValues<T>` dead export**
+
+- `src/schemas/index.ts` line 27 — never imported anywhere in production code
+- RemoteConfigStep uses `useForm` without this type
+- Fix: remove the unused export or wire it into RemoteConfigStep form typing
+
+**TD-4: Backend selection list hardcoded (not registry-driven)**
+
+- `BackendSelectionStep.tsx` `BACKENDS` constant lists 3 entries manually
+- Adding a backend to `BACKEND_REGISTRY` does not surface it in the selection UI
+- Fix: derive the `BACKENDS` display array from `Object.keys(BACKEND_REGISTRY)` with a display-name map
+
+---
+
+## Tech Debt Summary
+
+| Phase | Items | Severity |
+|-------|-------|---------|
+| 04-review-download-security | scriptTargets disconnect, missing Back button, 6 pending browser verifications | Medium/Info |
+| 01-foundation | BackendFormValues dead export | Info |
+| 03-wizard-ui | act() test warnings, hardcoded backend list | Info |
+
+**Total:** 8 items across 3 phases. No blockers.
+
+---
+
+## Nyquist Compliance
+
+| Phase | VALIDATION.md | nyquist_compliant | wave_0_complete | Status |
+|-------|---------------|-------------------|-----------------|--------|
+| 01-foundation | exists | false | false | PARTIAL |
+| 02-generators | exists | false | false | PARTIAL |
+| 03-wizard-ui | exists | false | false | PARTIAL |
+| 04-review-download-security | exists | false | false | PARTIAL |
+
+All 4 phases have VALIDATION.md files but none have been updated to `nyquist_compliant: true`. VALIDATION.md files were auto-generated as drafts but not finalized during execution.
+
+To address: run `/gsd:validate-phase N` for each phase needing Nyquist audit.
+
+---
+
+## Definition of Done Assessment
+
+From ROADMAP.md milestone success criteria:
+
+| Criterion | Status |
+|-----------|--------|
+| Vite dev server starts, React + TS app with no console errors | Human-verified (Phase 1) |
+| Backend Schema Registry defines Azure Blob, S3, S3-compatible | Verified (Phase 1) |
+| Zod schemas derived from registry, validate correct/incorrect input | Verified (Phase 1) |
+| WizardState reducer initializes, accepts dispatch, accessible via Context | Verified (Phase 1) |
+| buildRcloneConf() produces valid INI for all backends | Verified (Phase 2, 61 tests) |
+| Intune install: UTF-8 no-BOM, correct path, no credential logging | Verified (Phase 2) |
+| Intune detection: exits 0 when rclone.exe + config present | Verified (Phase 2) |
+| RMM script: self-contained, idempotent, SYSTEM-context safe | Verified (Phase 2) |
+| includeInstall toggle affects all generated scripts | Verified (Phase 2) |
+| Full wizard navigation (backend → config → deployment) end-to-end | Human-verified (Phase 3) |
+| Live rclone.conf preview, security gate, all downloads, ZIP, clipboard | Automated + human-pending (Phase 4) |
+
+---
+
+_Audited: 2026-03-27T16:00:00Z_
+_Auditor: Claude (gsd-audit-milestone orchestrator + gsd-integration-checker)_