kawa/Ready2Blob
1
0
Fork 0
Code Issues Pull Requests Actions Packages Activity

fix(08): revise plans based on checker feedback

Browse Source 
- 08-01 Task 2: change type="auto" tdd="true" to type="tdd" (schema consistency)
- 08-02 Task 2: fix inverted on-role tokens in ReviewStep migration
  bg-on-success -> bg-success/10, bg-on-warning -> bg-warning/10
- 08-02 mapping comment: same fix for consistency

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
kawa
2026-03-31 18:11:02 +02:00
co-authored by Claude Opus 4.6
parent bee3bad93a
commit 2ea0a1faaf
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.planning/phases/08-theme-foundation/08-01-PLAN.md
+1 -1
View File
@@ -144,7 +144,7 @@ Use vanilla JS (no arrow functions) for maximum browser compat in the inline scr
<done>src/index.css contains @custom-variant, @layer base with :root and .dark blocks (15 token pairs), @theme mapping all tokens. index.html has inline blocking script reading r2b-theme from localStorage. Vite build succeeds with no errors.</done> <done>src/index.css contains @custom-variant, @layer base with :root and .dark blocks (15 token pairs), @theme mapping all tokens. index.html has inline blocking script reading r2b-theme from localStorage. Vite build succeeds with no errors.</done>
</task> </task>
<task type="auto" tdd="true"> <task type="tdd">
<name>Task 2: Create ThemeToggle component with tests and wire into App.tsx</name> <name>Task 2: Create ThemeToggle component with tests and wire into App.tsx</name>
<files>src/components/ui/ThemeToggle.tsx, src/components/ui/ThemeToggle.test.tsx, src/App.tsx</files> <files>src/components/ui/ThemeToggle.tsx, src/components/ui/ThemeToggle.test.tsx, src/App.tsx</files>
<behavior> <behavior>
.planning/phases/08-theme-foundation/08-02-PLAN.md
+4 -4
View File
@@ -119,8 +119,8 @@ focus:ring-red-300 -> focus:ring-error/50
text-red-600 -> text-error text-red-600 -> text-error
text-red-500 -> text-error text-red-500 -> text-error
focus:ring-blue-300 -> focus:ring-primary/50 focus:ring-blue-300 -> focus:ring-primary/50
text-green-700 bg-green-50 -> text-success bg-on-success (or bg-success/10) text-green-700 bg-green-50 -> text-success bg-success/10
bg-yellow-50 border-yellow-300 text-yellow-800/900 -> bg-on-warning border-warning text-warning bg-yellow-50 border-yellow-300 text-yellow-800/900 -> bg-warning/10 border-warning text-warning
--> -->
</context> </context>
@@ -200,8 +200,8 @@ Continue the mechanical migration for all wizard components. Do NOT change DOM s
- `bg-blue-600 text-white ... hover:bg-blue-700` (Next button) -> `bg-primary text-on-primary ... hover:bg-primary` - `bg-blue-600 text-white ... hover:bg-blue-700` (Next button) -> `bg-primary text-on-primary ... hover:bg-primary`
**ReviewStep.tsx** (6 occurrences): **ReviewStep.tsx** (6 occurrences):
- `text-green-700 bg-green-50` (client-side notice) -> `text-success bg-on-success` - `text-green-700 bg-green-50` (client-side notice) -> `text-success bg-success/10`
- `bg-yellow-50 border border-yellow-300` (security warning box) -> `bg-on-warning border border-warning` - `bg-yellow-50 border border-yellow-300` (security warning box) -> `bg-warning/10 border border-warning`
- `text-yellow-800` (warning title) -> `text-warning` - `text-yellow-800` (warning title) -> `text-warning`
- `text-yellow-900` (warning label) -> `text-warning` - `text-yellow-900` (warning label) -> `text-warning`
- `border border-gray-300 ... hover:bg-gray-50` (Back button) -> `border border-outline ... hover:bg-surface` - `border border-gray-300 ... hover:bg-gray-50` (Back button) -> `border border-outline ... hover:bg-surface`