docs(09-04): gap closure plan for BackendSelectionStep TextFieldMD3 migration

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

.planning/phases/09-md3-components/09-VERIFICATION.md

@@ -0,0 +1,180 @@
+---
+phase: 09-md3-components
+verified: 2026-04-01T09:55:00Z
+status: gaps_found
+score: 11/12 must-haves verified
+re_verification: false
+gaps:
+  - truth: "All text inputs in the wizard render with floating labels that animate on focus and when the field has content"
+    status: partial
+    reason: "BackendSelectionStep's 'Remote name' input (id=remote-name) is a plain <input> element, not TextFieldMD3. COMP-01 says 'All text inputs' — this field was not in Plan 03's scope but is a text input visible to the user in step 1."
+    artifacts:
+      - path: "src/components/wizard/BackendSelectionStep.tsx"
+        issue: "Lines 58-59: plain <label> + <input> instead of TextFieldMD3. No floating label."
+    missing:
+      - "Replace the Remote name label+input block in BackendSelectionStep with a TextFieldMD3 component, passing register('name') as registration and the appropriate label/error/required props."
+human_verification:
+  - test: "Floating label visual animation"
+    expected: "Labels in RemoteConfigStep and PasswordField inputs animate upward on focus and stay floated when a value is typed. On blur with empty field, label returns to center position."
+    why_human: "CSS :placeholder-shown pseudo-class behavior and transition animation cannot be verified with jsdom — JSDOM does not compute CSS or trigger CSS transitions."
+  - test: "MD3 button visual appearance"
+    expected: "Next/Download-All buttons appear as pill-shaped (rounded-full) with primary fill color. Back/Copy/Download buttons appear as pill-shaped with an outline border and transparent background."
+    why_human: "Tailwind class presence is verified programmatically, but rendered visual output (actual computed styles, color tokens resolving correctly) requires browser inspection."
+  - test: "StepIndicator visual states"
+    expected: "Step 1 shows a highlighted numbered circle (primary color ring). Completed steps show a checkmark circle. Connector lines between steps are filled (primary) for completed segments and muted (outline) for future. Dark mode renders correctly with no hardcoded colors."
+    why_human: "Semantic token resolution (bg-primary, border-outline etc.) to actual CSS custom property values requires browser rendering."
+  - test: "BackendCard elevation and shape"
+    expected: "Backend cards display with visibly rounded corners (rounded-xl = 12px) and a subtle shadow. Hovering an unselected card increases shadow. Selected card has elevated shadow."
+    why_human: "Shadow rendering and hover state transitions require browser inspection."
+---
+
+# Phase 9: MD3 Components Verification Report
+
+**Phase Goal:** Implement MD3 component library — TextFieldMD3 with floating labels, MD3 button hierarchy, step indicator, card elevation
+**Verified:** 2026-04-01T09:55:00Z
+**Status:** gaps_found
+**Re-verification:** No — initial verification
+
+## Goal Achievement
+
+### Observable Truths
+
+All truths are drawn from the `must_haves.truths` sections across Plans 01, 02, and 03.
+
+| # | Truth | Status | Evidence |
+|---|-------|--------|----------|
+| 1 | TextFieldMD3 renders an outlined input with a floating label that floats on focus | VERIFIED | `src/components/ui/TextFieldMD3.tsx` uses `peer-focus:top-3 peer-focus:scale-75` CSS peer utilities; 9/9 unit tests pass |
+| 2 | TextFieldMD3 floating label floats when the field has a value | VERIFIED | `peer-[:not(:placeholder-shown)]:top-3 peer-[:not(:placeholder-shown)]:scale-75` applied; `placeholder=" "` drives CSS detection |
+| 3 | TextFieldMD3 preserves htmlFor/id pairing so getByLabelText queries work | VERIFIED | `<label htmlFor={id}>` + `<input id={id}>` pattern; Test 2 explicitly verifies `getByLabelText` |
+| 4 | MD3 button class constants exist for filled, outlined, and text variants | VERIFIED | `src/styles/md3-buttons.ts` exports `MD3_BTN_FILLED`, `MD3_BTN_OUTLINED`, `MD3_BTN_TEXT` with correct rounded-full classes |
+| 5 | FieldRenderer text-branch tooltip button uses aria-label instead of sr-only span | VERIFIED | Line 88-91 of FieldRenderer.tsx: `aria-label={\`More info about \${field.label}\`}` on button with plain ⓘ text; 4/4 DEBT-01 tests pass |
+| 6 | Step indicator shows numbered circles for each wizard step | VERIFIED | StepIndicator.tsx lines 49-61: `w-8 h-8 rounded-full` spans with `{i + 1}` content for active/future steps |
+| 7 | Completed steps display a checkmark and are clickable buttons | VERIFIED | Lines 36-45: `<button>` with `&#10003;` checkmark; test confirms `b.textContent?.includes('Backend')` selector works |
+| 8 | Current step is visually highlighted with primary color | VERIFIED | Active step uses `border-primary bg-primary/10 text-primary font-bold` — no hardcoded colors |
+| 9 | Future steps appear muted | VERIFIED | Future steps use `border-outline text-on-surface-container/40` semantic tokens |
+| 10 | Connector lines link steps — filled for completed, muted for future | VERIFIED | `bg-primary` if `isCompleted` else `bg-outline`; `aria-hidden="true"` applied |
+| 11 | Clicking step 0 dispatches SET_REMOTE_PARAMS({}) then SET_STEP(0) | VERIFIED | `handleStepClick` logic unchanged; StepIndicator test 4 verifies params are cleared; test 5 verifies deployment state preserved |
+| 12 | All text inputs in the wizard render with floating labels | PARTIAL | FieldRenderer text-branch and PasswordField use TextFieldMD3 (verified). BackendSelectionStep's "Remote name" input (lines 58-59) is a plain `<label>`+`<input>` with no floating label. |
+
+**Score: 11/12 truths verified** (1 partial gap)
+
+---
+
+### Required Artifacts
+
+#### Plan 01 Artifacts
+
+| Artifact | Expected | Status | Details |
+|----------|----------|--------|---------|
+| `src/components/ui/TextFieldMD3.tsx` | MD3 outlined text field with CSS floating label | VERIFIED | 75 lines, exports `TextFieldMD3`, spreads `{...registration}` onto input (line 41) |
+| `src/components/ui/TextFieldMD3.test.tsx` | Unit tests for floating label behavior | VERIFIED | 137 lines (>30 min), 9 tests covering all 8 required behaviors + 1 extra |
+| `src/styles/md3-buttons.ts` | MD3 button class constants | VERIFIED | Exports `MD3_BTN_FILLED`, `MD3_BTN_OUTLINED`, `MD3_BTN_TEXT` as string constants |
+| `src/components/ui/FieldRenderer.test.tsx` | Tests for DEBT-01 aria-label consistency | VERIFIED | 81 lines (>20 min), 4 tests covering text-branch and select-branch patterns |
+
+#### Plan 02 Artifacts
+
+| Artifact | Expected | Status | Details |
+|----------|----------|--------|---------|
+| `src/components/wizard/StepIndicator.tsx` | Rebuilt MD3 step indicator with circles and connectors | VERIFIED | 77 lines (>40 min), exports `StepIndicator`, uses `useWizard()` for state and dispatch |
+
+#### Plan 03 Artifacts
+
+| Artifact | Expected | Status | Details |
+|----------|----------|--------|---------|
+| `src/components/ui/FieldRenderer.tsx` | Text-branch using TextFieldMD3 | VERIFIED | Imports and renders `TextFieldMD3` at lines 5 and 100-107 |
+| `src/components/ui/PasswordField.tsx` | Password field using TextFieldMD3 layout | VERIFIED | Imports and renders `TextFieldMD3` at lines 3 and 46-53 with suffix prop |
+| `src/components/ui/BackendCard.tsx` | MD3 elevation and shape | VERIFIED | `rounded-xl` on line 17; `shadow` / `shadow-md` / `hover:shadow-md` on lines 19-20 |
+| `src/components/wizard/BackendSelectionStep.tsx` | MD3 filled button for Next | VERIFIED | Imports `MD3_BTN_FILLED` (line 9); applied to Next button (line 76) |
+
+---
+
+### Key Link Verification
+
+| From | To | Via | Status | Details |
+|------|----|-----|--------|---------|
+| `TextFieldMD3.tsx` | `react-hook-form` | `{...registration}` spread onto input | VERIFIED | Line 41: `{...registration}` spreads `UseFormRegisterReturn` onto `<input>` |
+| `FieldRenderer.tsx` | `TextFieldMD3.tsx` | `import { TextFieldMD3 }` + render | VERIFIED | Line 5 import; line 100 renders `<TextFieldMD3>` in text-branch |
+| `PasswordField.tsx` | `TextFieldMD3.tsx` | `import { TextFieldMD3 }` + render with suffix | VERIFIED | Line 3 import; line 46 renders `<TextFieldMD3 suffix={toggleButton}>` |
+| `BackendSelectionStep.tsx` | `src/styles/md3-buttons.ts` | `import { MD3_BTN_FILLED }` | VERIFIED | Line 9 import; line 76 className applied |
+| `RemoteConfigStep.tsx` | `src/styles/md3-buttons.ts` | `import { MD3_BTN_FILLED, MD3_BTN_OUTLINED }` | VERIFIED | Line 14 import; lines 114 and 121 applied to Back/Next buttons |
+| `DeploymentStep.tsx` | `src/styles/md3-buttons.ts` | `import { MD3_BTN_FILLED, MD3_BTN_OUTLINED }` | VERIFIED | Line 6 import; lines 95 and 100 applied to Back/Next buttons |
+| `ReviewStep.tsx` | `src/styles/md3-buttons.ts` | `import { MD3_BTN_FILLED, MD3_BTN_OUTLINED }` | VERIFIED | Line 6 import; line 131 (Back = OUTLINED), line 143 (Download All = FILLED) |
+| `OutputBlock.tsx` | `src/styles/md3-buttons.ts` | `import { MD3_BTN_OUTLINED }` | VERIFIED | Line 6 import; line 24 `smallBtn` constant uses `MD3_BTN_OUTLINED` with size overrides |
+| `StepIndicator.tsx` | `src/store/context.tsx` | `useWizard()` for state.currentStep and dispatch | VERIFIED | Line 7 import; line 12 `const { state, dispatch } = useWizard()` |
+
+---
+
+### Requirements Coverage
+
+| Requirement | Source Plan(s) | Description | Status | Evidence |
+|-------------|---------------|-------------|--------|----------|
+| COMP-01 | 09-01, 09-03 | All text inputs render as MD3 outlined fields with floating labels | PARTIAL | FieldRenderer text-branch and PasswordField use TextFieldMD3. BackendSelectionStep "Remote name" is still a plain input — gap logged above. |
+| COMP-02 | 09-03 | Buttons follow MD3 hierarchy — filled for primary, outlined for secondary | VERIFIED | All 4 wizard steps + OutputBlock import and apply MD3_BTN_FILLED / MD3_BTN_OUTLINED correctly |
+| COMP-03 | 09-03 | Cards and output blocks use MD3 elevation with shape tokens | VERIFIED | BackendCard: `rounded-xl` + `shadow`/`shadow-md`; OutputBlock pre: `rounded-xl shadow-sm` |
+| COMP-04 | 09-02 | Step indicator shows numbered circles with checkmarks, highlighted current, muted future | VERIFIED | StepIndicator rebuilt with circles, connector lines, semantic tokens, 5/5 WIZD-03 tests pass |
+| DEBT-01 | 09-01 | FieldRenderer uses consistent aria-label across text-branch and select-branch | VERIFIED | Both branches use `aria-label={\`More info about \${field.label}\`}` pattern; 4/4 tests pass |
+
+**REQUIREMENTS.md Traceability Cross-Check:**
+All 5 IDs (COMP-01, COMP-02, COMP-03, COMP-04, DEBT-01) are mapped to Phase 9 in REQUIREMENTS.md and all are marked `[x]` Complete. COMP-01 has a partial gap (BackendSelectionStep remote-name field). No orphaned requirements found.
+
+---
+
+### Anti-Patterns Found
+
+| File | Line | Pattern | Severity | Impact |
+|------|------|---------|----------|--------|
+| `src/components/wizard/ReviewStep.tsx` | 16, 27 | `PLACEHOLDER` constant and use | Info | Legitimate empty-state UX string, not a stub — renders when config cannot be built |
+| `src/components/wizard/BackendSelectionStep.tsx` | 58-59 | Plain `<label>` + `<input>` (no TextFieldMD3) | Warning | Remote name field is visually inconsistent with all other text inputs; COMP-01 partially unmet |
+
+No `style={{}}` props remain in StepIndicator. No hardcoded hex color codes found in any phase-09 modified file. No TODO/FIXME/HACK comments found.
+
+---
+
+### Human Verification Required
+
+#### 1. Floating Label CSS Animation
+
+**Test:** Navigate to RemoteConfigStep. Click into a text field, then click away without typing. Then type a value, blur, then clear it.
+**Expected:** On focus, the label smoothly translates upward and scales to 75%. When a value is present and the field is blurred, the label stays floated. When the value is cleared, the label returns to center.
+**Why human:** JSDOM does not compute CSS transitions or `:placeholder-shown` pseudo-class behavior. The Tailwind `peer-[:not(:placeholder-shown)]` arbitrary variant is untested by jsdom.
+
+#### 2. MD3 Button Visual Appearance
+
+**Test:** Navigate through all wizard steps and observe button appearances at each step.
+**Expected:** Next/Download-All = pill shape with solid primary background color. Back/Copy/Download = pill shape with a visible outline border and no fill. Disabled state shows reduced opacity.
+**Why human:** `MD3_BTN_*` class strings are applied correctly (verified), but the visual rendering of semantic tokens (`bg-primary`, `border-outline`, etc.) requires actual CSS custom property resolution in a browser.
+
+#### 3. StepIndicator Visual States in Browser
+
+**Test:** Complete step 1 (Backend selection) and observe the step indicator.
+**Expected:** Step 1 circle shows a checkmark and is clickable. Step 2 circle is highlighted with a primary color border/background. Step 3 and 4 appear muted. The connector line between step 1 and 2 is filled (primary color), between 2-3 and 3-4 it is muted.
+**Why human:** Semantic token resolution and visual differentiation of states requires browser rendering.
+
+#### 4. Dark Mode Consistency
+
+**Test:** Toggle to dark mode and navigate through all wizard steps.
+**Expected:** All MD3 components render correctly with no hardcoded colors bleeding through. Floating label color changes on focus/error still work. Card shadows remain visible but subtle.
+**Why human:** CSS custom property values under the dark theme class cannot be verified without rendering.
+
+---
+
+### Gaps Summary
+
+One gap blocks full COMP-01 satisfaction:
+
+**BackendSelectionStep "Remote name" field (src/components/wizard/BackendSelectionStep.tsx, lines 58-59)** is a plain `<label htmlFor="remote-name">` + `<input id="remote-name">` element. It was not included in Plan 03's integration scope (which targeted FieldRenderer and PasswordField). This means one user-facing text input in the wizard lacks a floating label, contradicting COMP-01's "All text inputs" requirement.
+
+The fix is straightforward: replace lines 58-62 in BackendSelectionStep with a `TextFieldMD3` component rendering the same `register('name')` registration and error state. No architectural changes required — the pattern is already established.
+
+All other phase goals are fully achieved:
+- TextFieldMD3 is a substantive, well-tested component with proper CSS floating label mechanics
+- MD3 button constants exist with correct MD3 semantics and are wired into all wizard steps
+- StepIndicator is fully rebuilt with MD3 circles, connector lines, and semantic tokens
+- DEBT-01 aria-label inconsistency is resolved across both FieldRenderer branches and PasswordField
+- All 179 test suite tests pass with zero regressions
+- All 5 commits documented in summaries (9441dcd, 532a994, b704844, e560a6a, d7a2cad) are confirmed in git history
+
+---
+
+_Verified: 2026-04-01T09:55:00Z_
+_Verifier: Claude (gsd-verifier)_