Manual test: fishing rods against the original #52

New Issue

2026-10-03T01:11:45+02:00

kawa commented

2026-10-03 01:11:45 +02:00

Why a person: the automated tests check the fishing poses, the bite and the hooked battle against our own reading of the ROM. They can't tell whether it looks and feels like the original game.

Setup (on a machine with the ROM)

MAKE_TEST_SAVES=1 npx vitest run tests/human-test-saves.test.ts writes test-saves/field-items.crystal-save.json.
npm run dev, load the ROM, then Savegames → Import native backup → that file, then Play.

The save stands on New Bark Town's shore facing right, at the sea, with CYNDAQUIL (L8) and PIDGEY (L4). The pack holds 5 POTION, 2 FLOWER MAIL and a REPEL; the Key Items pocket holds the BICYCLE and the OLD, GOOD and SUPER ROD.

Steps and expected results

Start → PACK → right twice (Key Items) → OLD ROD → USE. The menus close and the player holds the rod out over the water, facing right.
After about a second and a half: either "Not even a nibble!" or the player jiggles four times, a "!" bubble appears above the head, and after another second "Oh! A bite!". The "!" is gone once the text shows.
After "Not even a nibble!" + A, the player stands normally again.
After "Oh! A bite!" + A, the player stands normally and a battle opens with "The hooked attacked!" (not "Wild appeared!"). With the OLD ROD here it is a level 10 MAGIKARP or TENTACOOL; the GOOD ROD gives level 20 MAGIKARP, TENTACOOL, CHINCHOU or SHELLDER; the SUPER ROD level 40 CHINCHOU, SHELLDER, TENTACRUEL or LANTURN. About half the casts get a bite.
Turn away from the water (face up, left or down here) and use a rod: "OAK: CHRIS! This isn't the time to use that!" and no fishing pose.
Register a rod with SEL (Key Items → the rod → SEL), then press Select facing the water: it fishes the same way.
Walk west along Route 29 to Cherrygrove City and fish at the water's edge facing up, left and down. The rod points up above the head, out to the left, and down below the feet; Cherrygrove gives MAGIKARP, KRABBY, CORSOLA (day) or STARYU (night), and KINGLER with the SUPER ROD.
If you can compare with the original (cartridge, emulator or video): the fishing body and rod in each direction, the jiggle, the "!" and the pauses before the texts look the same.

Known differences, don't report these: no sound and no cry. Qwilfish and Remoraid swarms can't happen yet (they come from trainer phone calls).

Report: tick each line that matches; for anything else, add a comment with a screenshot or a short video and what you expected.

Commits: 397dcef (fishing), 4cb4676 (the other field items)

Why a person: the automated tests check the fishing poses, the bite and the hooked battle against our own reading of the ROM. They can't tell whether it looks and feels like the original game. **Setup** (on a machine with the ROM) 1. `MAKE_TEST_SAVES=1 npx vitest run tests/human-test-saves.test.ts` writes `test-saves/field-items.crystal-save.json`. 2. `npm run dev`, load the ROM, then Savegames → Import native backup → that file, then Play. The save stands on New Bark Town's shore facing right, at the sea, with CYNDAQUIL (L8) and PIDGEY (L4). The pack holds 5 POTION, 2 FLOWER MAIL and a REPEL; the Key Items pocket holds the BICYCLE and the OLD, GOOD and SUPER ROD. **Steps and expected results** - [ ] Start → PACK → right twice (Key Items) → OLD ROD → USE. The menus close and the player holds the rod out over the water, facing right. - [ ] After about a second and a half: either "Not even a nibble!" or the player jiggles four times, a "!" bubble appears above the head, and after another second "Oh! A bite!". The "!" is gone once the text shows. - [ ] After "Not even a nibble!" + A, the player stands normally again. - [ ] After "Oh! A bite!" + A, the player stands normally and a battle opens with "The hooked <name> attacked!" (not "Wild <name> appeared!"). With the OLD ROD here it is a level 10 MAGIKARP or TENTACOOL; the GOOD ROD gives level 20 MAGIKARP, TENTACOOL, CHINCHOU or SHELLDER; the SUPER ROD level 40 CHINCHOU, SHELLDER, TENTACRUEL or LANTURN. About half the casts get a bite. - [ ] Turn away from the water (face up, left or down here) and use a rod: "OAK: CHRIS! This isn't the time to use that!" and no fishing pose. - [ ] Register a rod with SEL (Key Items → the rod → SEL), then press Select facing the water: it fishes the same way. - [ ] Walk west along Route 29 to Cherrygrove City and fish at the water's edge facing up, left and down. The rod points up above the head, out to the left, and down below the feet; Cherrygrove gives MAGIKARP, KRABBY, CORSOLA (day) or STARYU (night), and KINGLER with the SUPER ROD. - [ ] If you can compare with the original (cartridge, emulator or video): the fishing body and rod in each direction, the jiggle, the "!" and the pauses before the texts look the same. Known differences, don't report these: no sound and no cry. Qwilfish and Remoraid swarms can't happen yet (they come from trainer phone calls). **Report**: tick each line that matches; for anything else, add a comment with a screenshot or a short video and what you expected. Commits: 397dcef (fishing), 4cb4676 (the other field items)

kawa added this to the Pokemon Crystal - Web project 2026-10-03 01:11:45 +02:00

kawa moved this to A tester in Pokemon Crystal - Web on 2026-10-03 01:11:45 +02:00

PestoRosso self-assigned this 2026-10-03 15:12:44 +02:00

PestoRosso added the P0 - now parity labels 2026-10-03 15:19:49 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kawa/Crystal#52